From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73587 invoked by alias); 4 Apr 2016 13:42:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73573 invoked by uid 89); 4 Apr 2016 13:42:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 04 Apr 2016 13:42:09 +0000 Received: by mail-pa0-f50.google.com with SMTP id fe3so144738259pab.1 for ; Mon, 04 Apr 2016 06:42:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=L/Xn7y2t1yVXmBkhE7K/tczsZpLdqsODj2RiIVqvmfE=; b=V2kpwl22BbkAE11bjYDL6hmvJ7TlxJz1oOU1sMTzT8ra6P7XRamwkUVlnbK2O6kzeZ jj+HZ0yxcI2i8sQczAC7w95zP86q0TMgRDXVvhJnYNo3vHPeFv+5GyOYWxFYe0hbBCWv OwKzcgYiK6MSSAfOJCbhhw2TSxXQc54a42QbeN9S+38K3MskoIOsbmBLeipg8NJxj4Iv FZSv5x4bki78CsFyZouZfPaas4idr64FRdiIJvG1/w5rblBIyc76vLYOCbHCD4XyBdc1 cGIuQJzV7KGMyo875bGjjnIftudIJ3mqCmAtOTAUJ4Yhr2Cu0NSl3LKXeDhBfho5XGrr v05A== X-Gm-Message-State: AD7BkJKnXx4jesn2xfkUek4U7P3SKQ8DX2ktT0pvsbYlX+eA2MloRAYtk67RRhc8c9oeGA== X-Received: by 10.67.23.161 with SMTP id ib1mr51740044pad.156.1459777327664; Mon, 04 Apr 2016 06:42:07 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id ko9sm513734pab.37.2016.04.04.06.42.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 04 Apr 2016 06:42:07 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] fort_dyn_array: Support evaluation of dynamic elements inside arrays. References: <1458204189-13267-1-git-send-email-bernhard.heckel@intel.com> <1458204189-13267-3-git-send-email-bernhard.heckel@intel.com> Date: Mon, 04 Apr 2016 13:42:00 -0000 In-Reply-To: <1458204189-13267-3-git-send-email-bernhard.heckel@intel.com> (Bernhard Heckel's message of "Thu, 17 Mar 2016 09:43:08 +0100") Message-ID: <86d1q5pk2g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00037.txt.bz2 Bernhard Heckel writes: > +# Check allocation status of dynamic array and it's dynamic members s/it's/its/ > diff --git a/gdb/valarith.c b/gdb/valarith.c > index 7959f3b..62d0e30 100644 > --- a/gdb/valarith.c > +++ b/gdb/valarith.c > @@ -207,6 +207,15 @@ value_subscripted_rvalue (struct value *array, LONGE= ST index, int lowerbound) > error (_("no such vector element")); > } >=20=20 > + if (is_dynamic_type (elt_type)) > + { > + gdb_byte *valaddr =3D NULL; > + CORE_ADDR address; > + > + address =3D value_address (array) + elt_offs; > + elt_type =3D resolve_dynamic_type (elt_type, valaddr, address); Pass NULL to resolve_dynamic_type, so valaddr can be removed. > + } > + > if (VALUE_LVAL (array) =3D=3D lval_memory && value_lazy (array)) > v =3D allocate_value_lazy (elt_type); > else Patch looks good to me, otherwise. --=20 Yao (=E9=BD=90=E5=B0=A7)