From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57405 invoked by alias); 24 Feb 2017 16:14:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57295 invoked by uid 89); 24 Feb 2017 16:14:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f179.google.com Received: from mail-wr0-f179.google.com (HELO mail-wr0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Feb 2017 16:14:57 +0000 Received: by mail-wr0-f179.google.com with SMTP id u47so16193772wrb.0 for ; Fri, 24 Feb 2017 08:14:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SsDt07AQTeNv5xO7mfzy5rQlRy6TpCUTxlFJwqN5z0s=; b=oeYWFlEv2OxbXyUIskyDhSAP04RCh17k0WQSpG80v4PtDGnbAkkABdar6eOmfdsMv+ WRfUhRNsRi8430QTBxELRJ8rwe9RQq2jldpxn/6TPctZWV8+6Uj9F4ongKQUzoPqxyyq EcnCfaOBjjA2qB2YrhhxzUBYOwTBUPKul4KkwfYOSz5DX+NvP+DcvWOOHVEDsONNf5IY mG7fFzkeBX3su3zxJvqDy2kU304nOyQK6ZTPu45DtuLgqz+xuIxq2epEokmOUt+8h8Og kadSW1YOgjIHqwdM2vt2g8CgyF1TUGMPRVnDN1an9K4d3aGzu9XK9WTFvaECEFW1RmZR PMiA== X-Gm-Message-State: AMke39n7Kg/UFMvXfOj7ipkLgp9xcFKSjobv1nLV0JZ8J9k+jao2pw4ADSFbTB27fbpTdQ== X-Received: by 10.223.169.140 with SMTP id b12mr3325622wrd.138.1487952895170; Fri, 24 Feb 2017 08:14:55 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id 17sm10910898wru.16.2017.02.24.08.14.54 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 24 Feb 2017 08:14:54 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from remote.c References: <00284BCB-10B9-41A6-BEFA-7873F4BB3B95@arm.com> Date: Fri, 24 Feb 2017 16:14:00 -0000 In-Reply-To: <00284BCB-10B9-41A6-BEFA-7873F4BB3B95@arm.com> (Alan Hayward's message of "Fri, 24 Feb 2017 10:06:42 +0000") Message-ID: <86d1e77eh1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00684.txt.bz2 Alan Hayward writes: > -enum register_status > -regcache_raw_read (struct regcache *regcache, int regnum, gdb_byte *buf) > +void > +regcache_raw_update (struct regcache *regcache, int regnum) > { > - gdb_assert (regcache !=3D NULL && buf !=3D NULL); > - gdb_assert (regnum >=3D 0 && regnum < regcache->descr->nr_raw_register= s); > /* Make certain that the register cache is up-to-date with respect > to the current thread. This switching shouldn't be necessary > only there is still only one target side register cache. Sigh! > On the bright side, at least there is a regcache object. */ > + > + gdb_assert (regcache !=3D NULL); > + gdb_assert (regnum >=3D 0 && regnum < regcache->descr->nr_raw_register= s); Nit, any reason you move these asserts from one place to another? It causes one unnecessary change. Could you change the assert in its original place? OK with this change. --=20 Yao (=E9=BD=90=E5=B0=A7)