From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9108 invoked by alias); 27 Jul 2017 11:17:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7941 invoked by uid 89); 27 Jul 2017 11:17:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1061, H*r:sk:static. X-HELO: mail-io0-f196.google.com Received: from mail-io0-f196.google.com (HELO mail-io0-f196.google.com) (209.85.223.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Jul 2017 11:17:07 +0000 Received: by mail-io0-f196.google.com with SMTP id q64so7497172ioi.0 for ; Thu, 27 Jul 2017 04:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oC8NYYLFA8TPLeyz3RCSCG5cgv0y1H9NkK+VZe8j/cI=; b=eLUVS4Apy9zX+EOeZsbIMdIlZ3mbuiXjMzO5j6Hgj19/T7XqyQ1jxZigE/trc7N2IA yjAE3jyUssBaXucjt3PdFUVPyGUjAGRNUeIwAUn5+y/VXJUD8J7VRbU+SSMWvbRSNMET Y/bwMne3qWiO7eCgfRLQhXIAnTRt2sAkvDyX7XSbb0X3NPmzB+YELaU+0608r9FeETfD vonGsZeDdb/g5ANekxrWrjeTfo6v8m4arhGZeW21X13tBw1X831d4gaCRWA9E5CTN+w7 Z3lxX/AAuUgdzfVstvj0IKJNsMS+9yaCSdD0bjE9M3RfTCjaS6a8fwgr2wIzcw7VagwZ 7oPQ== X-Gm-Message-State: AIVw111ix3ENC/8dIRD2aOj0GqJU4xHwW9yEs0Z8UMxtXPM5WjKkTnCA 0zOc7+OvG4bAdv1X X-Received: by 10.107.10.28 with SMTP id u28mr4478706ioi.172.1501154225228; Thu, 27 Jul 2017 04:17:05 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id l184sm8926321iol.43.2017.07.27.04.17.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 27 Jul 2017 04:17:04 -0700 (PDT) From: Yao Qi To: Wei-min Pan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v4] gdb: ADI support References: <1500424890-112103-1-git-send-email-weimin.pan@oracle.com> <86o9s8pmyg.fsf@gmail.com> Date: Thu, 27 Jul 2017 11:17:00 -0000 In-Reply-To: (Wei-min Pan's message of "Wed, 26 Jul 2017 14:12:25 -0700") Message-ID: <86d18mqgd1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00422.txt.bz2 Wei-min Pan writes: >>> +########################################## >>> +set newadi "7" >>> +gdb_test "adi x shmaddr" "" "examine ADI" >> Can you match the output? > > Here are the results of running this new test: > That is not what I mean. Your test leaves the PATTERN (the 2nd argument) empty, gdb_test "adi x shmaddr" "" "examine ADI" so it doesn't test much. You need to add PATTERN to match the expected output from command "adi x shmaddr". > % make check TESTS=3D"gdb.arch/sparc64-adi.exp" > ... > ... > > =3D=3D=3D gdb tests =3D=3D=3D > > Schedule of variations: > unix > > Running target unix > Using /usr/share/dejagnu/baseboards/unix.exp as board description file > for target. > Using /usr/share/dejagnu/config/unix.exp as generic interface file for > target. > Using ~/binutils-gdb/gdb/testsuite/config/unix.exp as > tool-and-target-specific interface file. > Running ~/binutils-gdb/gdb/testsuite/gdb.arch/sparc64-adi.exp ... > > =3D=3D=3D gdb Summary =3D=3D=3D > > # of expected passes 7 > ... --=20 Yao (=E9=BD=90=E5=B0=A7)