From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129706 invoked by alias); 22 Jun 2015 09:10:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129697 invoked by uid 89); 22 Jun 2015 09:10:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 22 Jun 2015 09:10:44 +0000 Received: by pabvl15 with SMTP id vl15so83947699pab.1 for ; Mon, 22 Jun 2015 02:10:42 -0700 (PDT) X-Received: by 10.66.165.8 with SMTP id yu8mr57098830pab.82.1434964242470; Mon, 22 Jun 2015 02:10:42 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id f1sm19154605pdp.24.2015.06.22.02.10.40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 22 Jun 2015 02:10:41 -0700 (PDT) From: Yao Qi To: Martin Galvan Cc: gdb-patches@sourceware.org Subject: Re: [PING][PATCH] testsuite: Escape a loose '[' character inside a regexp. References: <1434775646-2625-1-git-send-email-martin.galvan@tallertechnologies.com> Date: Mon, 22 Jun 2015 09:10:00 -0000 In-Reply-To: <1434775646-2625-1-git-send-email-martin.galvan@tallertechnologies.com> (Martin Galvan's message of "Sat, 20 Jun 2015 01:47:26 -0300") Message-ID: <86bng8rtva.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00430.txt.bz2 Martin Galvan writes: > Seems like an obvious fix to me, but I wanted to check just in case. > Ok to commit? Looks the code works well without this patch. Do we really need to escape '[' (and ']')? --=20 Yao (=E9=BD=90=E5=B0=A7)