Re: [PATCH c++ 2/5] m32c: Split m32c_move_reg_t in read/write variants

Yao Qi
2015-10-12T10:47:22Z

Simon Marchi <simon.marchi@polymtl.ca> writes:

> /* Register move functions. We declare them here using
> - m32c_move_reg_t to check the types. */
> -static m32c_move_reg_t m32c_raw_read, m32c_raw_write;
> -static m32c_move_reg_t m32c_banked_read, m32c_banked_write;
> -static m32c_move_reg_t m32c_sb_read, m32c_sb_write;
> -static m32c_move_reg_t m32c_part_read, m32c_part_write;
> -static m32c_move_reg_t m32c_cat_read, m32c_cat_write;
> -static m32c_move_reg_t m32c_r3r2r1r0_read, m32c_r3r2r1r0_write;
> -
> + m32c_{read,write}_reg_t to check the types. */
> +static m32c_read_reg_t m32c_raw_read,
> + m32c_banked_read,
> + m32c_sb_read,
> + m32c_part_read,
> + m32c_cat_read,
> + m32c_r3r2r1r0_read;
> +
> +static m32c_write_reg_t m32c_raw_write,
> + m32c_banked_write,
> + m32c_sb_write,
> + m32c_part_write,
> + m32c_cat_write,
> + m32c_r3r2r1r0_write;

I don't think this complies to GNU Coding Standard, which says
"Don’t declare multiple variables in one declaration that spans
lines. Start a new declaration on each line, instead."

Otherwise, patch is OK.

--
Yao (齐尧)