Re: [PATCH c++ 3/5] mep: Add cast for int to enum conversion

Yao Qi
2015-10-12T10:35:05Z

Simon Marchi <simon.marchi@polymtl.ca> writes:

Hi Simon,
Patch is OK, one nit below,

> @@ -2396,7 +2396,10 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
> /* The way to get the me_module code depends on the object file
> format. At the moment, we only know how to handle ELF. */
> if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour)
> - me_module = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK;
> + {
> + int flag = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK;

A blank line is needed here.

> + me_module = (CONFIG_ATTR) flag;
> + }
> else
> me_module = CONFIG_NONE;
> }

--
Yao (齐尧)