From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128948 invoked by alias); 12 Oct 2015 10:47:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128882 invoked by uid 89); 12 Oct 2015 10:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f48.google.com Received: from mail-pa0-f48.google.com (HELO mail-pa0-f48.google.com) (209.85.220.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 12 Oct 2015 10:47:20 +0000 Received: by pabve7 with SMTP id ve7so93370051pab.2 for ; Mon, 12 Oct 2015 03:47:18 -0700 (PDT) X-Received: by 10.66.121.110 with SMTP id lj14mr33295167pab.61.1444646838513; Mon, 12 Oct 2015 03:47:18 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id so4sm17601783pbc.72.2015.10.12.03.47.16 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Mon, 12 Oct 2015 03:47:18 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH c++ 2/5] m32c: Split m32c_move_reg_t in read/write variants References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> <1444538238-7468-2-git-send-email-simon.marchi@polymtl.ca> Date: Mon, 12 Oct 2015 10:47:00 -0000 In-Reply-To: <1444538238-7468-2-git-send-email-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 11 Oct 2015 00:37:15 -0400") Message-ID: <86a8ro5pov.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00149.txt.bz2 Simon Marchi writes: > /* Register move functions. We declare them here using > - m32c_move_reg_t to check the types. */ > -static m32c_move_reg_t m32c_raw_read, m32c_raw_write; > -static m32c_move_reg_t m32c_banked_read, m32c_banked_write; > -static m32c_move_reg_t m32c_sb_read, m32c_sb_write; > -static m32c_move_reg_t m32c_part_read, m32c_part_write; > -static m32c_move_reg_t m32c_cat_read, m32c_cat_write; > -static m32c_move_reg_t m32c_r3r2r1r0_read, m32c_r3r2r1r0_write; > - > + m32c_{read,write}_reg_t to check the types. */ > +static m32c_read_reg_t m32c_raw_read, > + m32c_banked_read, > + m32c_sb_read, > + m32c_part_read, > + m32c_cat_read, > + m32c_r3r2r1r0_read; > + > +static m32c_write_reg_t m32c_raw_write, > + m32c_banked_write, > + m32c_sb_write, > + m32c_part_write, > + m32c_cat_write, > + m32c_r3r2r1r0_write; I don't think this complies to GNU Coding Standard, which says "Don=E2=80=99t declare multiple variables in one declaration that spans lines. Start a new declaration on each line, instead." Otherwise, patch is OK. --=20 Yao (=E9=BD=90=E5=B0=A7)