From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64819 invoked by alias); 10 Feb 2016 17:25:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64806 invoked by uid 89); 10 Feb 2016 17:25:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=clears X-HELO: mail-pf0-f171.google.com Received: from mail-pf0-f171.google.com (HELO mail-pf0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 10 Feb 2016 17:25:40 +0000 Received: by mail-pf0-f171.google.com with SMTP id e127so15095873pfe.3 for ; Wed, 10 Feb 2016 09:25:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=kHvoGz6JrrKKxqzU87dB+poQc0GExW2C8LuCp6hfTT8=; b=KAxxsPauMv7diyQlNspUE/QDWEF09JSvhoBNlH52aJjAfxyxaN7rGExExAeFhU4Omc bNXSSPNyPWXXI05rqVCMyOf8Wvg6mL0ikV9UuaTLXzS+LTaD2zHBqfO0tfhD7xXQRHaF aJmUQpXRAf/Xh+yJjpW3emTH2cXM5eSGjzY5q/N7mRaADp4r28yzIpMjK5cqyErsJZnT A9+MNcuu4mt/oLeQIS/ldecyNEtUciBNINU8vBC404TpgPwFp9qC5QO4SFV6Knk7QmF+ dsXBrvaR77mO6C/FN1LjVGZIfatkVLUbSSJCxTZWmX89+HRPph5NO6TxfVxCvW70Tke/ zKgQ== X-Gm-Message-State: AG10YORbv41hFAqKGzUkuw13noLBaAl3vAHIBZFTPv9fzzXRODGDuv8y5gwkh4ANTy9ztg== X-Received: by 10.98.89.4 with SMTP id n4mr58791108pfb.81.1455125138417; Wed, 10 Feb 2016 09:25:38 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id l14sm6543121pfb.73.2016.02.10.09.25.36 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 10 Feb 2016 09:25:37 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned References: <1455029644-6197-1-git-send-email-yao.qi@linaro.org> <86egckqztq.fsf@gmail.com> <56BB6ADB.6070909@redhat.com> Date: Wed, 10 Feb 2016 17:25:00 -0000 In-Reply-To: <56BB6ADB.6070909@redhat.com> (Pedro Alves's message of "Wed, 10 Feb 2016 16:52:43 +0000") Message-ID: <86a8n8qxyp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00309.txt.bz2 Pedro Alves writes: Hi Pedro, > Isn't this broken on big endian? AFAICS, we're reading 32-bits into > the higher 32-bits of a 64-bit variable. What do you mean by "this"? IIUC, "this" means regcache_raw_read_unsigned, rather than my patch. My patch just clears *VAL before passing it to collect_register, so it shouldn't break anything (I hope) on big endian. --=20 Yao (=E9=BD=90=E5=B0=A7)