From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64436 invoked by alias); 5 Apr 2016 11:47:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64417 invoked by uid 89); 5 Apr 2016 11:47:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.192.193, Hx-spam-relays-external:209.85.192.193, Hx-languages-length:1161 X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 05 Apr 2016 11:46:54 +0000 Received: by mail-pf0-f193.google.com with SMTP id r187so1140086pfr.2 for ; Tue, 05 Apr 2016 04:46:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DbiapeblkKA5s+SY0WdABaudGrhSEIy6FO88AVAEmFI=; b=WpGJU5pFrOFoJ5zcyxBAQQTfprkftMZiDAmzaLCfxRJN1zELgzxeeTZMKh3v8KNXXE oLqQTKNC3rJdI8maEoXDDQRaudvtbD4tLBCfGZzgRf2zUcB67nT/QZCAbYP250eGEgAk kuvaoKEXOd7MQ0k9AVJH3haFlkyQShTaZn939eR450R+54hew6FUk6RkJwpBa1MyZ86d Rtq6iO6R0PSdhdGSueeDBtOFwe0VYsK9zLzcNW8fvUtvCGY5636l5SJIdfPphxJg5H4Z +Rg5Jct/qfwVre349FimxodohxoZU+Lr5Ta8WZdvZOmZCFWXjEr5V3e0BeWLPO2G2wQP oQCQ== X-Gm-Message-State: AD7BkJKpu/3X5h953c1tRM7k+luTvslWvFgzyCLOcgZR8bpNq57MqEurdNVo/teaPi2Djg== X-Received: by 10.98.69.193 with SMTP id n62mr28307186pfi.46.1459856812887; Tue, 05 Apr 2016 04:46:52 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id r68sm46399264pfa.33.2016.04.05.04.46.50 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 05 Apr 2016 04:46:52 -0700 (PDT) From: Yao Qi To: Walfred Tedeschi Cc: palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: [PATCH V2] Improve user experience in printing Fortran derived types. References: <1458296757-6795-1-git-send-email-walfred.tedeschi@intel.com> Date: Tue, 05 Apr 2016 11:47:00 -0000 In-Reply-To: <1458296757-6795-1-git-send-email-walfred.tedeschi@intel.com> (Walfred Tedeschi's message of "Fri, 18 Mar 2016 11:25:57 +0100") Message-ID: <86a8l8nuqk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00070.txt.bz2 Walfred Tedeschi writes: > + int printed_field =3D 0; /* Number of fields printed. */ > struct type *elttype; > CORE_ADDR addr; > int index; > @@ -375,15 +376,34 @@ f_val_print (struct type *type, const gdb_byte *val= addr, int embedded_offset, > fprintf_filtered (stream, "( "); > for (index =3D 0; index < TYPE_NFIELDS (type); index++) > { > - int offset =3D TYPE_FIELD_BITPOS (type, index) / 8; > - > - val_print (TYPE_FIELD_TYPE (type, index), valaddr, > - embedded_offset + offset, > - address, stream, recurse + 1, > - original_value, options, current_language); > - if (index !=3D TYPE_NFIELDS (type) - 1) > - fputs_filtered (", ", stream); > - } Why don't we continue using this code above? so that do need to add 'printed_field'. > + struct value *field =3D > + ((struct value *)original_value, index); A space is needed after ")". > + struct type *field_type =3D check_typedef (TYPE_FIELD_TYPE (type, ind= ex)); > + > + > + if (TYPE_CODE (field_type) !=3D TYPE_CODE_FUNC) > + { We didn't do this check before, why do we need this check now? --=20 Yao (=E9=BD=90=E5=B0=A7)