From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64976 invoked by alias); 9 May 2016 07:38:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64949 invoked by uid 89); 9 May 2016 07:38:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:Mon X-HELO: mail-pf0-f182.google.com Received: from mail-pf0-f182.google.com (HELO mail-pf0-f182.google.com) (209.85.192.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 09 May 2016 07:38:42 +0000 Received: by mail-pf0-f182.google.com with SMTP id y69so72514336pfb.1 for ; Mon, 09 May 2016 00:38:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DSnnmePYATMKkNre42Loo9guP0rmnVbUYGEj1+mh4Aw=; b=MAe70TOUrc9S9aGqZfq6RI3vt3O7hcHttVpF6VT5qDCxX/Tv0AGff+2yXi0fnxpGvA 6DDMKrm91CRzp1u1Hra8kKZ9Lxo7rnNfCQzL1kDbZ5gkyfh/0xzDl94I9NQVxSe5ENb5 51TFrlEXoPqUQrcGjkAelWHgD0V8XtkNEBlI9OzDBXevjb8A+aLYUfkxbbSIdmqw26bN xJ0umbd97xe0tQG6lhAy4qpzLmeJZsYbI7JjfMeHNFN+G0HKdmuW3YY9Rawt6FGSwaPw YHrB49rk0WxdGdqtHeDrrpBmN5zHInEzAzTCqLbjyCPHT1TE1yY3OWMBR0WIMAgwKmsp 6wVw== X-Gm-Message-State: AOPr4FUNCnDA/S9gTQpa5Q5vysf6UixekJFrlmq2VgMuHzlMj28wN9Sxd25LZsuD78/wqQ== X-Received: by 10.98.23.150 with SMTP id 144mr48563553pfx.96.1462779520645; Mon, 09 May 2016 00:38:40 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id o63sm38097792pfj.30.2016.05.09.00.38.38 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 09 May 2016 00:38:39 -0700 (PDT) From: Yao Qi To: tbsaunde+binutils@tbsaunde.org Cc: gdb-patches@sourceware.org Subject: Re: [PATCH, committed] remove trivialy unused variables References: <1462666464-7737-1-git-send-email-tbsaunde+binutils@tbsaunde.org> Date: Mon, 09 May 2016 07:38:00 -0000 In-Reply-To: <1462666464-7737-1-git-send-email-tbsaunde+binutils@tbsaunde.org> (tbsaunde's message of "Sat, 7 May 2016 20:14:24 -0400") Message-ID: <86a8jzd6ku.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00138.txt.bz2 tbsaunde+binutils@tbsaunde.org writes: > @@ -206,8 +206,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch, > struct symtab_and_line sal; > CORE_ADDR pc; > CORE_ADDR loop_end; > - int found_store_lr =3D 0; > - int found_decr_sp =3D 0; > int srcreg; > int tgtreg; > signed short offset; > @@ -251,7 +249,6 @@ iq2000_scan_prologue (struct gdbarch *gdbarch, > cache->saved_regs[tgtreg] =3D -((signed short) (insn & 0xffff)); >=20=20 > if (tgtreg =3D=3D E_LR_REGNUM) > - found_store_lr =3D 1; We should remove line "if (tgtreg =3D=3D E_LR_REGNUM)" as well, otherwise, the code behavior is changed. > continue; > } >=20=20 --=20 Yao (=E9=BD=90=E5=B0=A7)