From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17704 invoked by alias); 23 Feb 2017 16:02:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17691 invoked by uid 89); 23 Feb 2017 16:02:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 16:02:46 +0000 Received: by mail-wm0-f67.google.com with SMTP id r18so595212wmd.3 for ; Thu, 23 Feb 2017 08:02:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0MqQ+ZHHPYLQ+ZQRYidVKg3Cz1bw5daMPLIgC7DNcGk=; b=OhfFNlHVb3kaZ/vRtmotE2WxavUkS6zfNR4kzlzo7E/wUXZ3FYuGkocRNTDLzwLOvu hJMUh31LmTLwbPLtC3M0aiW1tCgXgW2xDh+5OWmpE+rFFmJy+wd4Lf3nERJKc3vQb0/f 46vAHzgYRZZuPKcX5+OAvCRUOmxjxVULF7HdAXy8RbJmgLw2uUSS2ST+qIHl0Jlc5WFh GXotHorO1zblSQhfXEMWBU+Yqdf+SvRj7r7igaacTyQ5NothCPSYIPCB/zYaOeFVVLtI EEiJc5JrcxkLuUOiDQshC8d4m82bVOj2NMOTIGzs2SRHRofHXOhVzim1eXH1WgKXtPbh YGnA== X-Gm-Message-State: AMke39kBFoF/SMXJEdXgUJh9GjSkjsHzWjWvfkE52/2++KwZJi5ASaqxIxcFXyVL9GT2HQ== X-Received: by 10.28.68.10 with SMTP id r10mr3422244wma.68.1487865765083; Thu, 23 Feb 2017 08:02:45 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id o70sm6877400wmi.26.2017.02.23.08.02.44 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 23 Feb 2017 08:02:44 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Fix gdb.base/completion.exp with --target_board=dwarf4-gdb-index References: <1487775033-32699-1-git-send-email-palves@redhat.com> <1487775033-32699-4-git-send-email-palves@redhat.com> Date: Thu, 23 Feb 2017 16:02:00 -0000 In-Reply-To: <1487775033-32699-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Wed, 22 Feb 2017 14:50:33 +0000") Message-ID: <86a89cc2u6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00633.txt.bz2 Pedro Alves writes: Hi Pedro, I don't know much about symbtab, > - /* Find the symtab for SRCFILE (this loads it if it was not yet read > - in). */ > - s =3D lookup_symtab (srcfile); > - if (s =3D=3D NULL) > + /* Go through symtabs for SRCFILE and check the externs and statics > + for symbols which match. */ > + iterate_over_symtabs (srcfile, [&] (struct symtab *symtab) > { > - /* Maybe they typed the file with leading directories, while the > - symbol tables record only its basename. */ > - const char *tail =3D lbasename (srcfile); > - > - if (tail > srcfile) > - s =3D lookup_symtab (tail); This is removed, do we have something equivalent in iterate_over_symtabs? > - } > - > - /* If we have no symtab for that file, return an empty list. */ > - if (s =3D=3D NULL) > - return (return_val); > - > - /* Go through this symtab and check the externs and statics for > - symbols which match. */ > - > - b =3D BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (s), GLOBAL_BLOCK); > - ALL_BLOCK_SYMBOLS (b, iter, sym) > - { > - COMPLETION_LIST_ADD_SYMBOL (sym, sym_text, sym_text_len, text, wor= d); > - } > - > - b =3D BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (s), STATIC_BLOCK); > - ALL_BLOCK_SYMBOLS (b, iter, sym) > - { > - COMPLETION_LIST_ADD_SYMBOL (sym, sym_text, sym_text_len, text, wor= d); > - } > + add_symtab_completions (symtab->compunit_symtab, use SYMTAB_COMPUNIT (s) > + sym_text, sym_text_len, > + text, word, TYPE_CODE_UNDEF); Can you split this part out this patch as a pure refactor? --=20 Yao (=E9=BD=90=E5=B0=A7)