From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100323 invoked by alias); 28 Mar 2017 15:49:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100297 invoked by uid 89); 28 Mar 2017 15:49:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=essentially X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Mar 2017 15:49:41 +0000 Received: by mail-wm0-f44.google.com with SMTP id x124so2364383wmf.0 for ; Tue, 28 Mar 2017 08:49:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=NR0OTlf4M6lC7spVZi7ZD6WhD4FHM2gHuDw5JOB8MHw=; b=kQUSgiTyhR2RIaERYprdoitl2z4H074Me6e6GuojHrV5D6W59XI8WL7gZyhK+TLpWN wCc6IyUWYFq/YksTlAOcuZUY3ZLUaIo3CWaovc+8SVqRvGVQsa2PXEmpFxyg/ZKJLJfn lhWL0jdTN+zT/e3o2O32jZWdwLG1PcdcWYhfG8GYCrvSzHt2NMcsgYXESC8VwvCukdhS JjjxgeEe6JHOIjibhzyq+pO/ZOEkC9K3AmBAtBNHao/uHbTDDf7VI2TcenvkngVqjqlj tq7R6aowCnZiBHA1nS5QsJhyE0d28gMCj+OunP10NxWO1EGLF8cgaC2gINXkRVTnZ44D r1bQ== X-Gm-Message-State: AFeK/H2G7nFxJ9vyE3S4okgvwUuVullLFfR4XSDX+MsuUuoRyYEMKqNBQrbgHxymGV1EXQ== X-Received: by 10.28.12.147 with SMTP id 141mr15694933wmm.8.1490716180711; Tue, 28 Mar 2017 08:49:40 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id y65sm5384430wrb.50.2017.03.28.08.49.39 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 28 Mar 2017 08:49:39 -0700 (PDT) From: Yao Qi To: "Metzger\, Markus T" Cc: "gdb-patches\@sourceware.org" , "Wiederhake\, Tim" , "xdje42\@gmail.com" , Joel Brobecker Subject: Re: GDB 8.0 release/branching 2017-03-20 update References: <20170320201629.pbjzaqsnvs7dx7f2@adacore.com> <86zigevkv0.fsf@gmail.com> <86inn1utkp.fsf@gmail.com> <86inmzvrbx.fsf@gmail.com> <86shm2u47t.fsf@gmail.com> <86wpbbnf1f.fsf@gmail.com> <86shlyoggb.fsf@gmail.com> <86mvc5o7o4.fsf@gmail.com> Date: Tue, 28 Mar 2017 15:49:00 -0000 In-Reply-To: (Markus T. Metzger's message of "Tue, 28 Mar 2017 15:08:23 +0000") Message-ID: <86a885o0z2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00488.txt.bz2 "Metzger, Markus T" writes: >> struct PyGetSetDef py_insn_getset[] =3D >> { >> { "data", py_insn_data, NULL, "raw instruction data", NULL}, >> { "decoded", py_insn_decode, NULL, "decoded instruction", NULL}, >> { "size", py_insn_size, NULL, "instruction size in byte", NULL}, >> { "pc", py_insn_pc, NULL, "instruction address", NULL }, >> {NULL} >> }; > > This is for the (abstract) base-class, I assume. > Yes, it is the base class, but it is the implementation detail about the class is abstract or not. I haven't think about it yet. Again, I only care about python interface at this stage. > We don't store any data in the base class so the Python object would > contain the PyObject header and nothing else, correct? > > And the above functions would throw an exception or return None. > Correct? > I didn't go that far yet :) > >> struct PyGetSetDef btpy_insn_getset[] =3D >> { >> { "data", btpy_insn_data, NULL, "raw instruction data", NULL}, >> { "decoded", btpy_insn_decode, NULL, "decoded instruction", NULL}, >> { "size", btpy_insn_size, NULL, "instruction size in byte", NULL}, >> { "pc", btpy_insn_pc, NULL, "instruction address", NULL }, >>=20 >> { "number", btpy_number, NULL, "instruction number", NULL}, >> { "sal", btpy_sal, NULL, "instruction number", NULL}, >> {NULL} >> }; > > This is for the BtraceInstruction derived class, I assume. That's essent= ially > what Tim implemented. Correct? > > This doesn't look too far away from what we have in GDB today. I requested to change the python interface in Tim's patch, not the implementation. --=20 Yao (=E9=BD=90=E5=B0=A7)