From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75254 invoked by alias); 13 Jun 2017 08:07:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75226 invoked by uid 89); 13 Jun 2017 08:07:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-it0-f47.google.com Received: from mail-it0-f47.google.com (HELO mail-it0-f47.google.com) (209.85.214.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 08:07:32 +0000 Received: by mail-it0-f47.google.com with SMTP id m47so36448212iti.1 for ; Tue, 13 Jun 2017 01:07:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pHCUvYOtxr/GDcvgX5C70U0NfxPN+zIwbNXmO4a6GJA=; b=bfVbONPV3HbtocBuf8b8vAQzqpn7XEf3/6IQ4/j8jq/+ToCphBlqTm/SvVg6bAn/9h zd38Ygwg9Au7R3vPnba/Dw11gjcFvXjH5koDye3dg/pjOyJ5NHxq82W2I8TUAWJk00Cf XKielgFU+5nUW6C/p5mAM9Fc1ougbCIXpokiDDNXRsGcXp5d4zQJHbclARQKXKDTp1Od pZwDXhfqEz1G7jS6NWdKeUZJ0hTyPWU6yzfj3QWXXu1v73arEaIVpr9O7UDjuwo78qpT bYQVU3sjEZQB4BASUMdFBJGFgsHZd3sqr0acSwPa97sHtdIUCfWEqeou1/G/FprRARcl uE+A== X-Gm-Message-State: AODbwcDNzoSa+CluqoulFr5ZID6s8EEfVtsjExq4z3wg/hc8sOnb64Nb YVenqmlc2nZ37ZHc X-Received: by 10.36.115.10 with SMTP id y10mr16318756itb.44.1497341255353; Tue, 13 Jun 2017 01:07:35 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id h133sm3333813ioe.60.2017.06.13.01.07.33 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 13 Jun 2017 01:07:34 -0700 (PDT) From: Yao Qi To: "Maciej W. Rozycki" Cc: Subject: Re: [PATCH 01/25] Move initialize_tdesc_mips* calls from mips-linux-nat.c to mips-linux-tdep.c References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-2-git-send-email-yao.qi@linaro.org> Date: Tue, 13 Jun 2017 08:07:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Mon, 12 Jun 2017 16:25:11 +0100") Message-ID: <86a85ce2f2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00358.txt.bz2 "Maciej W. Rozycki" writes: > Can you please wrap the commit description such that it does not go past= =20 > 80th column? Bear in mind that GIT indents by 4 characters, but if you=20 > stick to our general 74-column rule for text you'll be good. > OK, I adjust the line width in the commit log. Patch below is pushed. --=20 Yao (=E9=BD=90=E5=B0=A7) =46rom 032bb6eae8a0166f9b5d2eac6960383c532ef6d1 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Tue, 13 Jun 2017 09:05:04 +0100 Subject: [PATCH] Move initialize_tdesc_mips* calls from mips-linux-nat.c to mips-linux-tdep.c All target descriptions except mips initialization are called in -tdep.c, instead of -nat.c, so this patch moves mips target descriptions initialization to -tdep.c. Secondly, I want to change the target descriptions from pre-generated to dynamical creation, so I want to test that these pre-generated target descriptions equal to these dynamically created ones. Move target descriptions initialization to -tdep.c files so we can test them in any hosts (if they are still -nat.c, we can only test them on mips-linux host.). gdb: 2017-06-13 Yao Qi * mips-linux-nat.c: Move include features/mips*-linux.c to mips-linux-tdep.c. (_initialize_mips_linux_nat): Move initialize_tdesc_mips* calls to mips-linux-tdep.c. * mips-linux-tdep.c: Include features/mips*-linux.c (_initialize_mips_linux_tdep): Call initialize_tdesc_mips* functions. * mips-linux-tdep.h (tdesc_mips_linux): Declare. (tdesc_mips_dsp_linux, tdesc_mips64_linux): Declare. (tdesc_mips64_dsp_linux): Declare. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2956819..c2bceeb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,16 @@ +2017-06-13 Yao Qi + + * mips-linux-nat.c: Move include features/mips*-linux.c to + mips-linux-tdep.c. + (_initialize_mips_linux_nat): Move initialize_tdesc_mips* calls + to mips-linux-tdep.c. + * mips-linux-tdep.c: Include features/mips*-linux.c + (_initialize_mips_linux_tdep): Call initialize_tdesc_mips* + functions. + * mips-linux-tdep.h (tdesc_mips_linux): Declare. + (tdesc_mips_dsp_linux, tdesc_mips64_linux): Declare. + (tdesc_mips64_dsp_linux): Declare. + 2017-06-12 Tom Tromey =20 * valprint.h (val_print_type_code_int): Remove. diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c index 8041d84..1fd3365 100644 --- a/gdb/mips-linux-nat.c +++ b/gdb/mips-linux-nat.c @@ -38,11 +38,6 @@ =20 #include "nat/mips-linux-watch.h" =20 -#include "features/mips-linux.c" -#include "features/mips-dsp-linux.c" -#include "features/mips64-linux.c" -#include "features/mips64-dsp-linux.c" - #ifndef PTRACE_GET_THREAD_AREA #define PTRACE_GET_THREAD_AREA 25 #endif @@ -803,10 +798,4 @@ triggers a breakpoint or watchpoint."), =20 linux_nat_add_target (t); linux_nat_set_new_thread (t, mips_linux_new_thread); - - /* Initialize the standard target descriptions. */ - initialize_tdesc_mips_linux (); - initialize_tdesc_mips_dsp_linux (); - initialize_tdesc_mips64_linux (); - initialize_tdesc_mips64_dsp_linux (); } diff --git a/gdb/mips-linux-tdep.c b/gdb/mips-linux-tdep.c index ccfdcdf..f144a2e 100644 --- a/gdb/mips-linux-tdep.c +++ b/gdb/mips-linux-tdep.c @@ -40,6 +40,11 @@ #include "xml-syscall.h" #include "gdb_signals.h" =20 +#include "features/mips-linux.c" +#include "features/mips-dsp-linux.c" +#include "features/mips64-linux.c" +#include "features/mips64-dsp-linux.c" + static struct target_so_ops mips_svr4_so_ops; =20 /* This enum represents the signals' numbers on the MIPS @@ -1739,4 +1744,10 @@ _initialize_mips_linux_tdep (void) GDB_OSABI_LINUX, mips_linux_init_abi); } + + /* Initialize the standard target descriptions. */ + initialize_tdesc_mips_linux (); + initialize_tdesc_mips_dsp_linux (); + initialize_tdesc_mips64_linux (); + initialize_tdesc_mips64_dsp_linux (); } diff --git a/gdb/mips-linux-tdep.h b/gdb/mips-linux-tdep.h index 407b577..cca4798 100644 --- a/gdb/mips-linux-tdep.h +++ b/gdb/mips-linux-tdep.h @@ -105,3 +105,9 @@ enum { /* Return 1 if MIPS_RESTART_REGNUM is usable. */ =20 int mips_linux_restart_reg_p (struct gdbarch *gdbarch); + +/* Target descriptions. */ +extern struct target_desc *tdesc_mips_linux; +extern struct target_desc *tdesc_mips64_linux; +extern struct target_desc *tdesc_mips_dsp_linux; +extern struct target_desc *tdesc_mips64_dsp_linux;