Re: [PATCH 3/4] Use flexible target descriptors for aarch64

Yao Qi
2017-11-22T15:47:16Z

Alan Hayward <Alan.Hayward@arm.com> writes:

> +#include <stdlib.h>
> +#include <string.h>
> #include "aarch64.h"
>
> -extern struct target_desc *tdesc_aarch64;
> +#ifdef GDBSERVER
> +#include "common/common-defs.h"
> +#include "common/gdb_vecs.h"
> +#include "common/vec.h"
> +#include "tdesc.h"
> +#else
> +#include "defs.h"
> +#include "target-descriptions.h"
> +#endif
> +

Do we need to include headers this way? We don't have that in
arch/i386.c and arch/amd64.c.

> diff --git a/gdb/features/aarch64-core.c b/gdb/features/aarch64-core.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..a735515ae67211d29634e7c39b375a36edef2bb1
> --- /dev/null
> +++ b/gdb/features/aarch64-core.c
> @@ -0,0 +1,72 @@
> +/* THIS FILE IS GENERATED. -*- buffer-read-only: t -*- vi:set ro:
> + Original: aarch64-core.xml.tmp */
> +

Looks this file is not generated by the recent GDB. Can you re-generate them?

--
Yao (齐尧)