From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92534 invoked by alias); 2 Mar 2018 11:11:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92518 invoked by uid 89); 2 Mar 2018 11:11:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f175.google.com Received: from mail-pf0-f175.google.com (HELO mail-pf0-f175.google.com) (209.85.192.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Mar 2018 11:11:17 +0000 Received: by mail-pf0-f175.google.com with SMTP id 17so3859707pfw.11 for ; Fri, 02 Mar 2018 03:11:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HLOGutdefiSECbLVkw9n8e8DrAF2QuvA3jBUeWLfo5M=; b=FtbNSirM5w3gIrgtpLRQ53Ys9BbDNdNVxULQlNuUgJksakQrL1R8AybAL2yF1B9rJJ j3kWiab+WxH3BIKY4UXuToOyiCE6U3eZv5vHE2DkjLmKD50hIE5iVAecCf4+9yTm4qLX P0bXoLmjAx+zT+/xh57hZcZ8hqbXpzAgT0+7az7Wj8YWfNaYlQA7Z6HDnq5+zjgZZASd pr4ll8OIlgu9pzWUZlKSxI+UVfEW2SGPUeYZn4Z3vEvj7FzixjZklPLE7iuLqn0foWRo tAoznLmedR06swSP6K40XatYNGeQulbqPWA0xtmL2sVRvjqZ7GHvtjqpBun0vZIf/l3P IjPg== X-Gm-Message-State: APf1xPCOX9c8RxjQlcusbs1omY8Bq4sAtaMXA1Z9prBuDRkCXLXNZ7/P 7Yt7WlDL5NuOzM2KCrfdvfA= X-Google-Smtp-Source: AG47ELvYft5l0r8mMPo0g2GMbuLYnUFc6zTcrwHxrgNIwBRt+hk/saJoJFRJU6UH1Jhc96YHO6BCuA== X-Received: by 10.99.108.199 with SMTP id h190mr4241525pgc.295.1519989075822; Fri, 02 Mar 2018 03:11:15 -0800 (PST) Received: from E107787-LIN (gcc114.osuosl.org. [140.211.9.72]) by smtp.gmail.com with ESMTPSA id p16sm13074227pfd.77.2018.03.02.03.11.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 02 Mar 2018 03:11:15 -0800 (PST) From: Yao Qi To: Sergio Durigan Junior Cc: GDB Patches , Simon Marchi , Pedro Alves , Joel Brobecker , Christophe Lyon Subject: Re: [PATCH] Conditionally include "" on common/pathstuff.c (and unbreak build on mingw*) References: <20180301202005.11563-1-sergiodj@redhat.com> Date: Fri, 02 Mar 2018 11:11:00 -0000 In-Reply-To: <20180301202005.11563-1-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Thu, 1 Mar 2018 15:20:05 -0500") Message-ID: <86a7vq4trr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00049.txt.bz2 Sergio Durigan Junior writes: > Introduced a regression when compiling for mingw*: > > /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr > gdb_realpath(const char*)': > /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in th= is scope > char buf[MAX_PATH]; Fedora-x86_64-w64-mingw32 catches this build failure https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/11= 13/steps/compile%20gdb/logs/stdio but it doesn't send notification on build failure. Could you change the buildbot config to send notification on build failure? The same as other builders do. --=20 Yao (=E9=BD=90=E5=B0=A7)