From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FyLgGNc2c2lNGxEAWB0awg (envelope-from ) for ; Fri, 23 Jan 2026 03:52:39 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=b3y8VCkl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 568C11E0AD; Fri, 23 Jan 2026 03:52:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A412D1E08D for ; Fri, 23 Jan 2026 03:52:38 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 204A14BC89BE for ; Fri, 23 Jan 2026 08:52:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 204A14BC89BE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=b3y8VCkl Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id CD0544BA2E29 for ; Fri, 23 Jan 2026 08:52:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD0544BA2E29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD0544BA2E29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769158332; cv=none; b=GQD9Op2UVA+KKsv0qE8cWsI+OpiOTnhN/sjRViDgAFbTBvEMvSmgFpsppAOiNEbsvTi1ID5/W+1g4NBcUf+g8O1GxUfo3OLJwTxSghT5Ki4DiCguTUSUIqVYPwp3Kuo4tFTSOfo4Ql2Ax24sdjcP37ljfPwtbEbDuFTOBDAZ5W8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769158332; c=relaxed/simple; bh=w0Hd/z2O7MOVLMWsfXnCLIsH70u8m2zvnhxg2nFoMdU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=sZcWLBBo/ccL76Rg1wrqVtzLMG05dgr8prsawsNX/vpu/4GJYKjj2Q6pFd8MaSD2kIbEows0L0S4/jrdRZXo1yTNNLjv2ACW+fnOKHTs8G0zxuwQPPbObSfATdULBiJW1RRj9kFOoTusn9jiZq0OYW9k9fNUpa2CL4TC23564N0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD0544BA2E29 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vjCtm-0006WI-8n; Fri, 23 Jan 2026 03:52:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=6GZ/B/5g7hGO2P/0TpPMXjnohIit5dNy/3+GzbtUikA=; b=b3y8VCklAKMtVjZ5lBjl a9O+ou5Anc1fuYKeooCnXcjvOlhpgtp3GGz6yErAMyeWHzR8vWbfdHafwDKRv5Q2DO0j6Z/6BiNkg JhZ40TdHbaeoydli+nHRq1RjXObUhVRwYaEGbWQbsPio+KlVfMILcXnLwyFLwp7R0yfdEcTWr382k p/1CazmZbnDsgnRb+pOTOihiZbk3Yeev7VeBMJM95jqpdTYidjipOsm+dbJ7sb/ca0s8CTDQ5C9eY iYuf9SItm3gMiDHtOY3AU2YItaoykuV/6x/4kJmY3IiIAzxboIvAZ+peBlAUtKZAEIDX1b5zviO52 FGyfK6R9FhYPjA==; Date: Fri, 23 Jan 2026 10:52:05 +0200 Message-Id: <86a4y4iudm.fsf@gnu.org> From: Eli Zaretskii To: Christina Schimpe Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org In-Reply-To: <20260123080532.878738-7-christina.schimpe@intel.com> (message from Christina Schimpe on Fri, 23 Jan 2026 08:05:28 +0000) Subject: Re: [PATCH v2 6/9] gdb: Add command option 'bt -shadow' to print the shadow stack backtrace. References: <20260123080532.878738-1-christina.schimpe@intel.com> <20260123080532.878738-7-christina.schimpe@intel.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Christina Schimpe > Cc: thiago.bauermann@linaro.org > Date: Fri, 23 Jan 2026 08:05:28 +0000 > > gdb/NEWS | 3 + > gdb/amd64-linux-tdep.c | 26 + > gdb/annotate.c | 93 +++- > gdb/annotate.h | 18 +- > gdb/doc/gdb.texinfo | 27 + > gdb/gdbarch-gen.c | 32 ++ > gdb/gdbarch-gen.h | 15 +- > gdb/gdbarch_components.py | 20 +- > gdb/shadow-stack.c | 480 +++++++++++++++++- > gdb/shadow-stack.h | 6 + > gdb/stack.c | 73 +-- > gdb/stack.h | 55 ++ > .../gdb.arch/amd64-shadow-stack-cmds.exp | 88 ++++ > gdb/testsuite/gdb.base/options.exp | 2 +- > 14 files changed, 875 insertions(+), 63 deletions(-) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 74fc353d7e9..37b3add11ed 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,9 @@ > > *** Changes since GDB 17 > > +* New "-shadow" command line option for the backtrace command to print the > + shadow stack backtrace instead of the normal backtrace. > + > * Support for .gdb_index sections with version less than 7 has been > removed. This part is okay. > +A shadow stack is supported, for instance, with the Intel Control-Flow > +Enforcement Technology (@xref{CET}) on x86 and the Guarded Control Stack > +feature (@xref{GCS}) on AArch64. ^^^^^^^^^^ This should use @pxref, not @xref. > +This option may be combined with “-frame-info” and implies ‘-no-filters’ > +and ‘-frame-arguments none’. ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ All those should use @code and without the quotes. > +@node GCS > @subsubsection AArch64 Guarded Control Stack > @cindex Guarded Control Stack, AArch64 > @cindex GCS, AArch64 > @@ -27248,6 +27274,7 @@ registers > > @end itemize > > +@node CET > @subsubsection Intel Control-Flow Enforcement Technology. > @cindex Intel Control-Flow Enforcement Technology. You are adding @node's, but AFAICT you don't change the @menu of the parent section. That can only work with recent Texinfo versions, where @menus are updated automatically. Please update the parent @menu as part of the patch, to not rely on those recent versions. Reviewed-By: Eli Zaretskii