Re: [PATCH 08/24] Make gdb.base/sizeof.exp use gdb_test_stdio

Antoine Tremblay
2015-04-23T15:36:18Z

On 04/21/2015 02:08 PM, Pedro Alves wrote:
> gdb/testsuite/ChangeLog:
> 2015-04-21 Pedro Alves <palves@redhat.com>
>
> * gdb.base/sizeof.exp (check_sizeof, check_valueof): Use
> gdb_test_stdio.
> ---
> gdb/testsuite/gdb.base/sizeof.exp | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/sizeof.exp b/gdb/testsuite/gdb.base/sizeof.exp
> index 7fda76e..a237ee3 100644
> --- a/gdb/testsuite/gdb.base/sizeof.exp
> +++ b/gdb/testsuite/gdb.base/sizeof.exp
> @@ -70,8 +70,10 @@ set sizeof_long_double [get_sizeof "long double" 8]
> proc check_sizeof { type size } {
> global gdb_prompt
>
> - set pat [string_to_regexp "sizeof (${type}) == ${size}"]
> - gdb_test "next" "${pat}\[\r\n\]+\[0-9\].*" "check sizeof \"$type\""
> + set pat [string_to_regexp "sizeof (${type}) == ${size}\r\n"]
> + gdb_test_stdio "next" "${pat}" \
> + "\[0-9\].*" \
> + "check sizeof \"$type\""
> }
>
> check_sizeof "char" ${sizeof_char}
> @@ -90,8 +92,10 @@ check_sizeof "long double" ${sizeof_long_double}
> proc check_valueof { exp val } {
> global gdb_prompt
>
> - set pat [string_to_regexp "valueof (${exp}) == ${val}"]
> - gdb_test "next" "${pat}\[\r\n\]+\[0-9\].*" "check valueof \"$exp\""
> + set pat [string_to_regexp "valueof (${exp}) == ${val}\r\n"]
> + gdb_test_stdio "next" "${pat}" \
> + "\[0-9\].*" \
> + "check valueof \"$exp\""
> }
>
> # Check that GDB and the target agree over the sign of a character.
>

It's not part of the patch but should we replace :

# Test depends on printf, which the sparclet stub doesn't support.
if { [istarget "sparclet-*-*"] } {
return 0
}

With :if [target_info exists gdb,noinferiorio] { ?

This is present in other tests too...

Thanks,
Antoine

And add that option to the sparclet target ? ( I could not find that
target in the tree even if config/m32r-stub.exp references it...