Re: [PATCH 1/2] arm-tdep.c: Remove unused arm_displaced_step_copy_insn

Simon Marchi
2016-02-11T19:15:04Z

On 16-02-11 05:54 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> This function is never used, since it is superseded by
>> arm_linux_displaced_step_copy_insn.
>>
>> gdb/ChangeLog:
>>
>> * arm-tdep.c (arm_displaced_step_copy_insn): Remove.
>> * arm-tdep.h (arm_displaced_step_copy_insn): Remove.
>
> arm_displaced_step_copy_insn is still referenced in the comments in
> arm-linux-tdep.c,
>
> /* Linux-specific displaced step instruction copying function. Detects when
> the program has stepped into a Linux kernel helper routine (which must be
> handled as a special case), falling back to arm_displaced_step_copy_insn()
> if it hasn't. */
>
> Can you remove it from the comments as well? These comments can be
> simplified further like
>
> /* Implement the "displaced_step_copy_insn" gdbarch method. */
>
> OK with the change like this.
>

Thanks, both patches pushed, with the change in this one.