Re: [PATCH 1/3] Generalize gdb.reverse/aarch64.exp

Pedro Alves
2016-02-24T11:22:05Z

On 02/22/2016 04:53 PM, Yao Qi wrote:
> I said we can generialize gdb.reverse/aarch64.exp for other
> architectures https://sourceware.org/ml/gdb-patches/2015-05/msg00482.html
> and here is the patch to change aarch64.exp to insn-reverse.exp.
>
> gdb/testsuite:
>
> 2016-02-22 Yao Qi <yao.qi@linaro.org>
>
> * gdb.reverse/aarch64.c: Rename it ...
> * gdb.reverse/insn-reverse.c: to ...
> [__aarch64__] Include arm_neon.h.
> (testcase_ftype): New.
> (testcases): New array.
> (n_testcases): New.
> (main): Call each element in testcases.
> * gdb.reverse/aarch64.exp: Rename it ...
> * gdb.reverse/insn-reverse.exp: to ...
> Remove is_aarch64_target check.
> (read_testcase): New.
> Do the tests in a loop.
> ---
> gdb/testsuite/gdb.reverse/aarch64.c | 99 ----------------------
> gdb/testsuite/gdb.reverse/aarch64.exp | 115 -------------------------
> gdb/testsuite/gdb.reverse/insn-reverse.c | 121 +++++++++++++++++++++++++++
> gdb/testsuite/gdb.reverse/insn-reverse.exp | 130 +++++++++++++++++++++++++++++

Can you send a "git diff -M" so we can easily see the actual
changes? (You can make that the default with git config.)

Though I think even better would be to do the rename in one patch,
and the generalization changes in a separate patch.

Thanks,
Pedro Alves