From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54916 invoked by alias); 24 Mar 2017 08:49:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54899 invoked by uid 89); 24 Mar 2017 08:49:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f174.google.com Received: from mail-pf0-f174.google.com (HELO mail-pf0-f174.google.com) (209.85.192.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 08:49:13 +0000 Received: by mail-pf0-f174.google.com with SMTP id 20so4804823pfk.2 for ; Fri, 24 Mar 2017 01:49:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CyLVH9QuTnRyx2fkpikGHASSC/XSBvpGg579TkLos9E=; b=rYoJ+LAa/b7aq9BY1hCCIzhp7yIVWHwIYBifMf8LYsQG9K39vWCqBC2AZd9MKMWL1w 6phZUr5EJudjJUhABfduBaxThmPvXuHWhxarB/WdmXXAVtXYlwKoUTALozjWPzmXW8oy FpcYoNreLR6KNPX3WPjv5t2YPpYZqfzxSY/Prs7b2Q9x1J65a3gqUc5+Hb/OsKoAYFyi Bi6S2XABAyisX+nX6GzXw6wW+xwaCCBdnozPISxn1o282tUzbtyM/ieDaLMMVsfOxFLR itXEQA04zLiZu6ywFgclHlXHV3uwa3Sq82bcfLr+tEqqMCf1/K1k0UrTb/AYKwDDMSJG q85Q== X-Gm-Message-State: AFeK/H22OuQ9ZI/PDNg4ppD1wy5wlMY1UyT7grbXqpz05CJTaUXzMi0ZFCL17wQ94vIPRg== X-Received: by 10.98.87.216 with SMTP id i85mr7894704pfj.151.1490345353302; Fri, 24 Mar 2017 01:49:13 -0700 (PDT) Received: from E107787-LIN (gcc114.osuosl.org. [140.211.9.72]) by smtp.gmail.com with ESMTPSA id d63sm3051273pfg.132.2017.03.24.01.49.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 24 Mar 2017 01:49:12 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from regcache.c References: <562B2F6F-F3C6-4A76-9489-57539F396C94@arm.com> Date: Fri, 24 Mar 2017 08:49:00 -0000 In-Reply-To: <562B2F6F-F3C6-4A76-9489-57539F396C94@arm.com> (Alan Hayward's message of "Fri, 24 Feb 2017 10:19:11 +0000") Message-ID: <868tnvukjh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00428.txt.bz2 Alan Hayward writes: > @@ -126,6 +129,8 @@ init_regcache_descr (struct gdbarch *gdbarch) > descr->register_offset[i] =3D offset; > offset +=3D descr->sizeof_register[i]; > gdb_assert (MAX_REGISTER_SIZE >=3D descr->sizeof_register[i]); Do we still need to keep MAX_REGISTER_SIZE? or you plan to remove it later. > + descr->max_register_size =3D std::max (descr->max_register_size, > + descr->sizeof_register[i]); > } > /* Set the real size of the raw register cache buffer. */ > descr->sizeof_raw_registers =3D offset; > @@ -1465,17 +1473,19 @@ regcache_dump (struct regcache *regcache, struct = ui_file *file, > fprintf_unfiltered (file, "Cooked value"); > else > { > - enum register_status status; > + struct value *value =3D regcache_cooked_read_value (regcache, > + regnum); > > - status =3D regcache_cooked_read (regcache, regnum, buf); > - if (status =3D=3D REG_UNKNOWN) > - fprintf_unfiltered (file, ""); "" is lost after your patch. > - else if (status =3D=3D REG_UNAVAILABLE) > + if (value_optimized_out (value) > + || !value_entirely_available (value)) > fprintf_unfiltered (file, ""); > else > - print_hex_chars (file, buf, > + print_hex_chars (file, value_contents_all (value), > regcache->descr->sizeof_register[regnum], > gdbarch_byte_order (gdbarch)); > + > + release_value (value); > + value_free (value); --=20 Yao (=E9=BD=90=E5=B0=A7)