From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Cc: weimin.pan@oracle.com
Subject: File name convention ARCH-OSABI-tdep.c
Date: Wed, 21 Jun 2017 10:09:00 -0000 [thread overview]
Message-ID: <868tklhct8.fsf@gmail.com> (raw)
Hi,
I want to extend the *-tdep.c file name convention. The current
convention is ARCH-OSABI-tdep.c, and I want to extend it to
ARCH-OSABI-tdep-FUNC.c, in which FUNC is about a certain functionality
or feature about this target.
The sparc64 adi patch
(https://sourceware.org/ml/gdb-patches/2017-06/msg00472.html) adds a new
file sparc64-adi-tdep.c which should be merged to sparc64-tdep.c
according to the current naming convention. However, I think it is good
to put different things in different files. So with the new convention
proposed here, the new file can be sparc64-tdep-adi.c.
Secondly, some *-tdep.c files are already quite large, arm-tdep.c is of
399434 bytes, 13318 lines. It is the 5th largest file. arm-tdep.c
includes many things which are not related to each, like displaced
stepping and process record. I am thinking that we should allow people
moving them out of *-tdep.c to *-tdep-displaced.c and *-tdep-precord.c.
--
Yao (齐尧)
next reply other threads:[~2017-06-21 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 10:09 Yao Qi [this message]
2017-06-21 12:43 ` John Baldwin
2017-06-23 12:36 ` Ivo Raisr
2017-06-27 13:17 ` Pedro Alves
2017-06-28 19:28 ` Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868tklhct8.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox