From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54643 invoked by alias); 9 Aug 2017 13:41:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54585 invoked by uid 89); 9 Aug 2017 13:41:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:286, H*r:sk:static. X-HELO: mail-it0-f66.google.com Received: from mail-it0-f66.google.com (HELO mail-it0-f66.google.com) (209.85.214.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 13:41:57 +0000 Received: by mail-it0-f66.google.com with SMTP id t78so4669148ita.1 for ; Wed, 09 Aug 2017 06:41:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=aCJtXrZOEzcucCwsJ7N/Ol5KWmKw0wTSwAM9yB8I/BY=; b=dCsMFvC0rIYnsQpyYPv/SoiDjSWskpRn0F+ae5FNlmowqe4yUZTRkMVXP2VrcNREKb yipJ6Jtmb8/cu9Eas1Vp6CFh8+/8Ww9CUcBUvoymhuJkrPcJfLQ+FMpxr+wJTy7LZcCr 0oEo8Ehh//tP1pjqi8NEkVgY4fPoNA93lyFku6Ed3Zf8V8Q+4nV1umSIiRI/va170hnz uoELuw2jsqqgJe1MeG61HlXeZsF+t/UWffIXU++2F6Slpd/IFvL/vFnK9vugjWYaT0g3 VqXxyK2XkkXRBH1WLtG3d2xAA6goLrSzohZAeQBqhKpoYEykMHTZnP0cdFxg3BXTvWhU IB4w== X-Gm-Message-State: AIVw111yqVopG4KplLzgaVunybATta5l8/X5kOrCRajrXIAn0AW7Ov1V HspA8HxsmNu5JcM5 X-Received: by 10.36.79.13 with SMTP id c13mr6939877itb.26.1502286115502; Wed, 09 Aug 2017 06:41:55 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id f92sm1916587ioi.56.2017.08.09.06.41.54 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 09 Aug 2017 06:41:55 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Alex Lindsay , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string) References: <20170807201821.25207-1-alexlindsay239@gmail.com> <86k22dyno6.fsf@gmail.com> <2c88c7cb-dca8-7bd7-fe01-ee0c4a9d0e94@redhat.com> <2675604a-4460-81e3-93f3-21e34727fe12@redhat.com> Date: Wed, 09 Aug 2017 13:41:00 -0000 In-Reply-To: <2675604a-4460-81e3-93f3-21e34727fe12@redhat.com> (Pedro Alves's message of "Wed, 9 Aug 2017 13:31:08 +0100") Message-ID: <868tiszwmb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00181.txt.bz2 Pedro Alves writes: Patch is good to me. > - n =3D cp_comp_to_string (&newobj, 100); > + gdb::unique_xmalloc_ptr n =3D cp_comp_to_string (&newobj, 1= 00); Nit, it is too long. --=20 Yao (=E9=BD=90=E5=B0=A7)