From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +SxbMgjxHmjK0BwAWB0awg (envelope-from ) for ; Sat, 10 May 2025 02:24:08 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=r7d61mPm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF73E1E10E; Sat, 10 May 2025 02:24:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E66621E092 for ; Sat, 10 May 2025 02:24:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D5983857BB3 for ; Sat, 10 May 2025 06:24:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D5983857BB3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=r7d61mPm Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A8B2C3858D38 for ; Sat, 10 May 2025 06:23:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8B2C3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8B2C3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746858216; cv=none; b=mTs7exnKaEwTn+hazSkFm/yVMESf/z1fjvZaRMx54D8342Sutg+1Q4rLzu9T7+sKctDWe25jA+F5+fgOokaQx4ckxuEHWRAYE6d8L6rooAMi2Fl5UCMZ39vl8UnTxFTzVDxCNkeZDKPzum9ZK/KjnDCsYY88D8HcwRRzKb7GlY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746858216; c=relaxed/simple; bh=oNX7pe+n1M9yaj0lE5RZo7Fjqaragp6M1fTqKus7QF8=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=MdOmzlZgGcLBzu+dSrrHwE/dG8JkLD+irJbEjOZYJiQyZrpitnMbfSwFqYtxLX8fvDbolBKLE4foDM7ZrUN6r71DVj3R3DQpxy/SMisj6hcbYknIn5+hOR5c+xbY+SVv8GQFLvAzr+1/jJ92hqtn20JyAgBm7zas/HXxvWMQyHk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8B2C3858D38 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDdcN-0008M2-HG; Sat, 10 May 2025 02:23:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i+4aNnwvvCsklnhJ27VVY2eJvy1YoZKdvk7Yvk9k5ks=; b=r7d61mPma4+t OdlFniTqc+YCl9BZgYi7tW2Yc8dVpoTED7EXm3mnzzmGxQxq6SeJT+3C/3T0n+YX/YhryPxKHaobc etsfG7Q8mih8+7z5hWa1CS3i4hhy9LulpKRXKdneKiHRQ/sCQUI2IyNe+dkwjH+QVmeocorp7y5WY xVG8GNng1Ug0bRpjC3k3aBoF89qdkxpiUkAauje0gE8/qvVHfmWnJJ9uQrc9TTLSOj3QaleAL7srZ csuzKizoBWxN6B0ZlYY8S2e9XwuU3lqAQwPF4H4e7h0+WtgF0rGAcRP/zjftfrQCju1+darYHv4dV R/ui0HJnE26vJCje8/2MkA==; Date: Sat, 10 May 2025 09:23:24 +0300 Message-Id: <868qn5c7c3.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20250509-emoji-check-mark-v1-2-63b6c52411f3@adacore.com> (message from Tom Tromey on Fri, 09 May 2025 14:18:51 -0600) Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI References: <20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com> <20250509-emoji-check-mark-v1-2-63b6c52411f3@adacore.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom Tromey > Date: Fri, 09 May 2025 14:18:51 -0600 > Cc: Tom Tromey > > In keeping with the emojification of gdb, this patch changes the > default "current" marker to be a check-mark. It adds a knob to allow > the character to be changed, and, as always, reverts to the old output > when emojis are disabled. > --- > gdb/NEWS | 6 ++++++ > gdb/cli-out.c | 8 ++++++++ > gdb/cli-out.h | 2 ++ > gdb/cli/cli-style.c | 32 ++++++++++++++++++++++++++++++++ > gdb/cli/cli-style.h | 3 +++ > gdb/doc/gdb.texinfo | 10 ++++++++++ > gdb/testsuite/gdb.base/style.exp | 4 ++++ > 7 files changed, 65 insertions(+) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index a82b7e3342c57b9b066e9012c5a961ad6ba839f0..07e72833a269ffe0ab034d4c4ea8b185ad217983 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -78,6 +78,12 @@ set style error-prefix STRING > with emoji display, and so the prefixes are only displayed if emoji > styling is enabled. > > +set style check-mark STRING > + Set the string that is used to indicate the "current" row when a > + table is printed by the CLI. This functionality is intended for use > + with emoji display, and so the prefixes are only displayed if emoji > + styling is enabled. This part is okay. > + add_setshow_string_cmd ("check-mark", no_class, > + &check_mark, > + _("Set the check mark text."), > + _("Show the check mark text."), I suggest Set the check-mark string.\n\ Check-mark is the string used to indicate the current line in a table. > +@item set style check-mark @var{string} > +@itemx show style check-mark > +These commands control the string that the CLI uses to indicate which > +line in a table indicates the current state of @value{GDBN}. For > +example, this would be used to indicate the current thread in the > +output of @samp{info threads}. This functionality is intended for use > +with emoji display, and so the chosen string only displayed if emoji ^^^ "is" is missing there. Reviewed-By: Eli Zaretskii