From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17518-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13583 invoked by alias); 12 Aug 2002 18:10:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13571 invoked from network); 12 Aug 2002 18:10:02 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.250)
  by sources.redhat.com with SMTP; 12 Aug 2002 18:10:02 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7CI9sr9001083;
	Mon, 12 Aug 2002 20:09:54 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.5/8.12.5) with ESMTP id g7CI9smb029321;
	Mon, 12 Aug 2002 20:09:54 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.5/8.12.5/Submit) id g7CI9rCs029318;
	Mon, 12 Aug 2002 20:09:53 +0200 (CEST)
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:i386] Add mmx registers
References: <3D55A89F.9040300@ges.redhat.com>
From: Mark Kettenis <kettenis@chello.nl>
Date: Mon, 12 Aug 2002 11:10:00 -0000
In-Reply-To: Andrew Cagney's message of "Sat, 10 Aug 2002 19:58:23 -0400"
Message-ID: <867kiwkky6.fsf@elgar.kettenis.dyndns.org>
X-SW-Source: 2002-08/txt/msg00268.txt.bz2

Andrew Cagney <ac131313@ges.redhat.com> writes:

> Hello,
> 
> This adds mmx registers to the i386.

Great, a few nits though :-(

* Please rename is_mmx_regnum() to mmx_regnum_p().

* Please rename nr_mmx_regs to mmx_num_regs.

* Why do you use regcache_raw_read_as_address() in
  mmx_regnum_to_fp_regnum?  Looks misleading to me...

Mark