From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130514 invoked by alias); 11 Dec 2015 13:28:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130497 invoked by uid 89); 11 Dec 2015 13:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 11 Dec 2015 13:28:50 +0000 Received: by pacwq6 with SMTP id wq6so65591195pac.1 for ; Fri, 11 Dec 2015 05:28:48 -0800 (PST) X-Received: by 10.66.219.228 with SMTP id pr4mr24065249pac.99.1449840528553; Fri, 11 Dec 2015 05:28:48 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id hz8sm25760002pac.10.2015.12.11.05.28.46 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 11 Dec 2015 05:28:47 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v7.1] Support software single step on ARM in GDBServer. References: <1449583641-18156-7-git-send-email-antoine.tremblay@ericsson.com> <1449691701-11845-1-git-send-email-antoine.tremblay@ericsson.com> Date: Fri, 11 Dec 2015 13:28:00 -0000 In-Reply-To: <1449691701-11845-1-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Wed, 9 Dec 2015 15:08:21 -0500") Message-ID: <867fklqflh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00230.txt.bz2 Antoine Tremblay writes: > * linux-aarch32-low.c (arm_abi_breakpoint): Remove macro. Moved > to linux-aarch32-low.c. > (arm_eabi_breakpoint, arm_breakpoint): Likewise. > (arm_breakpoint_len, thumb_breakpoint): Likewise. > (thumb_breakpoint_len, thumb2_breakpoint): Likewise. > (thumb2_breakpoint_len): Likewise. I don't see how are they used outside of linux-aarch32-low.c, so why do you move them out to linux-aarch32-low.h? --=20 Yao (=E9=BD=90=E5=B0=A7)