From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10482 invoked by alias); 11 Apr 2017 10:02:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9970 invoked by uid 89); 11 Apr 2017 10:02:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=regi X-HELO: mail-wr0-f176.google.com Received: from mail-wr0-f176.google.com (HELO mail-wr0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 10:02:55 +0000 Received: by mail-wr0-f176.google.com with SMTP id z109so25374793wrb.1 for ; Tue, 11 Apr 2017 03:02:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=N9IXVuyZsMRQ+Yto+wQNs42nUSlS140kV/xKBiKsq/Q=; b=JTFlwrDS/zkuFSEcKoqZHhteIIc5gb66ntRLLcGZq1rl8vjZdwdMBHwa55xcGpmBBS u0gQx4qRoKKyYevszYKLdCY38gsf0I6PBL7kFKmhwu4sb+41l9joej859ina2TsZvN/M mGsPQVbgM3jxaQCWO5wYkZSankTWviSEXMWVWO2CtaXlBZedomzUWuxv6VbskEkyUsAI LCB+wa22sNlHG8SicXhd9drI8k+9PhfrF82e+dRPRqtOaNf+A791ODm7cL/jsXlTbU8R awi5EKCeWLYBq3T/O0qvARA9oWt+YWrjI9M77pEk5PeCsX3JjHmUIwqbSKkDI7B6+uE2 KScA== X-Gm-Message-State: AFeK/H3Dzw4oxaXc4ixmJ9cc+ytO38CrIqwXBEJE43A2OvBfnjTVa0Ztd4tPhxzLLHj5hw== X-Received: by 10.223.135.134 with SMTP id b6mr24804452wrb.48.1491904975470; Tue, 11 Apr 2017 03:02:55 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id c53sm20978500wra.16.2017.04.11.03.02.54 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 11 Apr 2017 03:02:54 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , Subject: Re: [PATCH 8/11] Add FRV_MAX_REGISTER_SIZE References: <3B3BD949-1C9D-44FF-AB6A-03091ECA49D0@arm.com> Date: Tue, 11 Apr 2017 10:02:00 -0000 In-Reply-To: <3B3BD949-1C9D-44FF-AB6A-03091ECA49D0@arm.com> (Alan Hayward's message of "Tue, 4 Apr 2017 10:14:49 +0000") Message-ID: <867f2rw9br.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00262.txt.bz2 Alan Hayward writes: > - char zerobuf[MAX_REGISTER_SIZE]; > + char zerobuf[FRV_MAX_REGISTER_SIZE]; > > - memset (zerobuf, 0, MAX_REGISTER_SIZE); > + memset (zerobuf, 0, FRV_MAX_REGISTER_SIZE); > > /* gr0 always contains 0. Also, the kernel passes the TBR value in > this slot. */ The code here fills some gr registers with zeros, /* gr0 always contains 0. Also, the kernel passes the TBR value in this slot. */ regcache_raw_supply (regcache, first_gpr_regnum, zerobuf); /* Fill gr32, ..., gr63 with zeros. */ for (regi =3D first_gpr_regnum + 32; regi <=3D last_gpr_regnum; regi++) regcache_raw_supply (regcache, regi, zerobuf); the size of these gr registers are know, 8 bytes. It won't be changed. We can do, gdb_byte zerobuf[8] =3D { 0 }; the code is still easy to read. If you really dislike magic number (IMO, 8 is not a magic number in this context), you can define FRR_GR_REGISTER_SIZE. Alternatively, you can add a new regache api, regcache_raw_supply_zero. Many places can use this api, and some uses of MAX_REGISTER_SIZE can be removed too, for example, regcache_raw_supply (regcache, MIPS_ZERO_REGNUM, zerobuf); --=20 Yao (=E9=BD=90=E5=B0=A7)