From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ava9KXjyw2lN9TgAWB0awg (envelope-from ) for ; Wed, 25 Mar 2026 10:34:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=cKr9tZaB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 957181E04F; Wed, 25 Mar 2026 10:34:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 52D4D1E04F for ; Wed, 25 Mar 2026 10:34:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D2B564BB58CD for ; Wed, 25 Mar 2026 14:34:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2B564BB58CD Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=cKr9tZaB Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 116FB4BB5890 for ; Wed, 25 Mar 2026 14:34:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 116FB4BB5890 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 116FB4BB5890 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774449245; cv=none; b=PbqGBiZIX8BVppWa0SugKlJM0iP+KsIked6ZBK048/rGgpFBojICL6svbJTAvI9VXHrJbuaibncJD8bSC+tAptvdMm6BG9xm0Hl2JgMF1ooPBGEYsznupqqqkobonhav8llvb3vJL8RNwHcYbQMQjSYmTa2g/OPf+DzWvQLIisc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774449245; c=relaxed/simple; bh=I04x6mWdlVwM/g71+/jpXEvfMmL71e/FC7MGCKfxVfI=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=p/JYea97rOr15iTzSvZgq4PTpxfhsEIcE5QzkuoXSXSe1CYHcpJ/QepcCuLxKhtBGYnINMO9kzhWCcbCh3GBMQzH75EjxSLUsXAivEWt0AzTLlaTwrbqGxVJB4nIHy7utlid/a8E2wjKiawZz9PbBbhZuxMg7jqPftHz8k8prws= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 116FB4BB5890 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w5PJ6-0005ID-5Q; Wed, 25 Mar 2026 10:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gm+z3lxz0wwUGxi2R12cQ4AsAllbed2jQnqsN/jdBtg=; b=cKr9tZaBR9yx 5BFMcepfCNs/ADKTZbNMCeF6igUkVBEGgoVhPCdCcPhOYkeffk6zSx0AN+sg4O/2tFrz8OiKbMR12 dUsO5EmwZwcYiIQ9Zh5rggvYnEGNuclvHVfO5kSd4MzW4SlFF6nlswlL2TxDgsmzMXPRRyjfsEVU5 0Ih71XyjxL9cgqF7zkN6hz/yjl3oGMOMcu12PKm69Ue7qq4kCUw/smqq9PjPw+583bJVzNV0JC5ll GjOttUia3I7I+AqqZSUu/yUpsr6Cp74lpK9vvvnU0NZQHarW1/wxlanVaJiwCl8wCuhsR86mVLBcQ /N5gMeqZGQ1Jw8lPWl/2Gw==; Date: Wed, 25 Mar 2026 16:34:00 +0200 Message-Id: <867br0x9k7.fsf@gnu.org> From: Eli Zaretskii To: Klaus Gerlicher Cc: gdb-patches@sourceware.org In-Reply-To: <20260325122321.315910-2-klaus.gerlicher@intel.com> (message from Klaus Gerlicher on Wed, 25 Mar 2026 12:23:21 +0000) Subject: Re: [PATCH v2 1/1] gdb: remember previously selected thread per inferior References: <20260325122321.315910-1-klaus.gerlicher@intel.com> <20260325122321.315910-2-klaus.gerlicher@intel.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Klaus Gerlicher > Date: Wed, 25 Mar 2026 12:23:21 +0000 > > gdb/NEWS | 7 + > gdb/doc/gdb.texinfo | 19 ++ > gdb/gdbthread.h | 4 + > gdb/inferior.c | 58 +++++- > gdb/inferior.h | 14 ++ > gdb/infrun.c | 6 +- > gdb/testsuite/gdb.base/inferior-switch.c | 42 +++++ > gdb/testsuite/gdb.base/inferior-switch.exp | 172 ++++++++++++++++++ > .../gdb.mi/user-selected-context-sync.exp | 14 ++ > gdb/thread.c | 8 + > 10 files changed, 341 insertions(+), 3 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/inferior-switch.c > create mode 100644 gdb/testsuite/gdb.base/inferior-switch.exp Thanks. > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,13 @@ > > *** Changes since GDB 17 > > +* By default, GDB now remembers which thread was selected when you were > + last working in each inferior. When you switch back to that inferior, > + GDB automatically restores the previous thread selection (if the thread > + still exists). You can disable this behavior with > + 'set remember-threads-per-inferior off' to use the original behavior > + of always selecting the first available thread. > + > * Support for .gdb_index sections with version less than 7 has been > removed. This part is okay. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index ceb69669ea6..dcbbcb273c1 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo This part is also okay, with one minor comment: > +When enabled (the default), switching to a previously used inferior will > +restore the thread that was active when you switched away. When disabled, ^^^^^^ I think we should say "selected" there, not "active". The latter is ambiguous in this context. Reviewed-By: Eli Zaretskii