From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40370 invoked by alias); 3 Dec 2015 11:27:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40355 invoked by uid 89); 3 Dec 2015 11:27:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pf0-f172.google.com Received: from mail-pf0-f172.google.com (HELO mail-pf0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 03 Dec 2015 11:27:10 +0000 Received: by pfnn128 with SMTP id n128so7621375pfn.0 for ; Thu, 03 Dec 2015 03:27:09 -0800 (PST) X-Received: by 10.98.13.211 with SMTP id 80mr12278066pfn.112.1449142029094; Thu, 03 Dec 2015 03:27:09 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id g79sm10176935pfj.13.2015.12.03.03.27.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 03 Dec 2015 03:27:07 -0800 (PST) From: Yao Qi To: Ruslan Kabatsayev Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64 References: <564F998D.5080406@gmail.com> <86mvttt7be.fsf@gmail.com> Date: Thu, 03 Dec 2015 11:27:00 -0000 In-Reply-To: (Ruslan Kabatsayev's message of "Wed, 2 Dec 2015 17:26:19 +0300") Message-ID: <86610fu60p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00041.txt.bz2 Ruslan Kabatsayev writes: > I did a `make check` for unpatched gdb-7.10 and patched with my > changes. Here's the unpatched result: Thanks for running the test. Could you test your patch against GDB git mainline please? The patch will be applied to mainline, so we need to test it against mainline. > > # of expected passes 32377 > # of unexpected failures 85 > # of unexpected successes 2 > # of expected failures 72 > # of unknown successes 2 > # of known failures 62 > # of untested testcases 36 > # of unsupported tests 201 > > And here's after my patch: > > # of expected passes 32378 > # of unexpected failures 85 > # of unexpected successes 2 > # of expected failures 71 > # of unknown successes 2 > # of known failures 62 > # of untested testcases 36 > # of unsupported tests 201 > > I.e. one "expected failure" less and one "expected pass" more. I'm not > sure how to interpret this result. > This may happen from time to time, especially in some gdb.threads tests. >>> gdb/ChangeLog: >>> >>> * configure.host: Fix detection of x86_64 host when setting >>> floatformats >> >> This line is too long, the max is 74. Sentence should be ended with ".". > > Should I resend the whole original mail with this fixed? Please post the changelog entry only for the reference. If there is no regression in the GDB mainline tests, and no objections from other people in 3 days, your patch can go in. Do you have write access to git repository and FSF copyright assignment? If you don't have them, I can commit it for you as a tiny patch. However, if you want to contribute more patches, you need an FSF copyright assignment, and git write access, so that you can push by yoursel= f. --=20 Yao (=E9=BD=90=E5=B0=A7)