From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54251 invoked by alias); 13 Apr 2017 10:06:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54229 invoked by uid 89); 13 Apr 2017 10:06:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f43.google.com Received: from mail-wm0-f43.google.com (HELO mail-wm0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 10:06:16 +0000 Received: by mail-wm0-f43.google.com with SMTP id t189so43175625wmt.1 for ; Thu, 13 Apr 2017 03:06:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DbpECaLSiI9nr7t21OVKY4gH+rMGoaAKZg58kltp0hc=; b=G+spNRB4oNEQ8ajEzpXTPw5a4xzDk6W6MCxAQOTNfY9+pFADcEz7pcsAygyeZuq1sa lk45LKkYBqJgUrUoFbVphytnEi1zgSiCi+CJq+sUycDItJ+5iYlma4HkHMJRSrPYHp7q szeNRRg0I6h7hecG8ZHpnUncjRPmLDQHHmkhNZMoITnzRhg1w5Gz8RVaoOAnk7v83Z3z SasE0xgheq9FRi5vMKVov6fCEmQY0V0/rMttjIS5+cPWZ2jIFM0kunrbkaaQ0zioNrOX 9nUfSpTKxzM/4JJLQ0luBm2tFsB4GMujXVohXiL1uSQrtAp80srfErz9Ow9tkzLgWHZ8 UPIw== X-Gm-Message-State: AN3rC/6CAZQNo+Toj5PSWVyVhDCUHg/TX5ljjkFSBETebosoRZExmK/N nrBpC/504nQign0N X-Received: by 10.28.30.19 with SMTP id e19mr2489182wme.52.1492077975807; Thu, 13 Apr 2017 03:06:15 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id 60sm28976925wrg.60.2017.04.13.03.06.14 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 13 Apr 2017 03:06:15 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] C++fy thread_apply_all_command References: <1491954673-29172-1-git-send-email-palves@redhat.com> <1491954673-29172-4-git-send-email-palves@redhat.com> Date: Thu, 13 Apr 2017 10:06:00 -0000 In-Reply-To: <1491954673-29172-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Wed, 12 Apr 2017 00:51:08 +0100") Message-ID: <8660i8aaga.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00410.txt.bz2 Pedro Alves writes: > yyyy-mm-dd Pedro Alves > > * thread.c: Include . > (thread_array_cleanup): Delete. > (scoped_inc_dec_ref): New class. > (live_threads_count): New function. > (set_thread_refcount): Delete. > (tp_array_compar_ascending): Now a bool. > (tp_array_compar): Convert to a std::sort comparison function. > (thread_apply_all_command): Use std::vector and scoped_inc_dec_ref > and live_threads_count. LGTM. --=20 Yao (=E9=BD=90=E5=B0=A7)