Re: [PATCH 0/5] Remove a few hurdles of compiling with clang

Eli Zaretskii
2017-06-14T02:29:29Z

> Date: Tue, 13 Jun 2017 22:17:15 +0200
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org
>
> On 2017-06-13 21:22, Eli Zaretskii wrote:
> > See, I don't consider the proposed solution to be elegant, because it
> > tweaks a perfectly valid code to placate a stupid compiler warning.
>
> It replaces perfectly valid code with some other perfectly valid code.

Which is not used anywhere else, right?

> We can always add comments like
>
> /* Don't use ALL_DEBUG_ADDRESS_REGISTERS here to silence Clang's
> -Wfor-loop-analysis warning. */

That's the least we should do, IMO.

Thanks.