From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S8jXHd7v1mUViCgAWB0awg (envelope-from ) for ; Thu, 22 Feb 2024 01:55:26 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Buk5CmII; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 69A631E0D2; Thu, 22 Feb 2024 01:55:26 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 305C61E092 for ; Thu, 22 Feb 2024 01:55:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87D0B385783F for ; Thu, 22 Feb 2024 06:55:23 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F03473858425 for ; Thu, 22 Feb 2024 06:55:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F03473858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F03473858425 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708584903; cv=none; b=SmEFZe9fcsta6k3JTGiTzFQviqLuKVkFHN9P6Tzvzn5HhokOBQem0U+f/5Gk4byJsflur5eQ7pztg5yVMTHa54Ycbysp4xVb1N5gnsoYjItHPohZya1CDyOiNCyN46ilWiEYZ2IYwIKc0bMDPDZZ7G19iziOcq0GlME+nzWFKWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708584903; c=relaxed/simple; bh=s5FwCxA5GxhCn95RnObsdJ4mWceRc5F0OLEAQuRj4fw=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=xEs7cDcFE5IlvSnxBgnD+JSONlsiJ/Umezk7pg37Wm1T5a+/uxUy9z1sHWLNFRktlUXUBkJAepapvibaqKwrOozxksSp5VKIjVp/myI3J/J1YlB5Rmz9aILvSHYSpZfhwWQ6XQkQN+ywqMB1JA3R3WzSAeBadc9duA10IQqpaO4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rd2yu-0002Nz-Ub; Thu, 22 Feb 2024 01:54:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hKOFCSdPlTQcnakPkdTfNWIRTOm5DbAV0fIiYUQpng8=; b=Buk5CmIIjjbf ZKPn0Z2M12pTEYDiydxo+qC7SkoXtLZGl4Up2WxGnp5GvGg786am+Bx9zChjj1T+/NXOS7GcNRylB 3Jz7DbZPm72sgK4yj03GAChKk6lXglCzoHKzUmI1R5LjxOXQivEw9m3k/3H4amybO0ULa2kKGTFCs B0SxeAh632p+o7SwXYsNyy/AptCKGGDzAon7q9jbkTvcF3Uw5myc7BJG8tZ2PAnWJMkYDp9HNi+v8 GKAjEkekZJjOr7ZxVOmMzIzadFTB45SSpTBZOLixX79nMU8//7E7Ka4w1L9sM5JS6hLTvA1YRLsD2 Y5PuadCTyyTnackR2UXc3g==; Date: Thu, 22 Feb 2024 08:54:49 +0200 Message-Id: <865xyhm1ja.fsf@gnu.org> From: Eli Zaretskii To: Tiezhu Yang Cc: gdb-patches@sourceware.org, kevinb@redhat.com, tom@tromey.com, blarsen@redhat.com In-Reply-To: <20240222033601.1758-1-yangtiezhu@loongson.cn> (message from Tiezhu Yang on Thu, 22 Feb 2024 11:36:01 +0800) Subject: Re: [PATCH v4] gdb: Modify the output of "info breakpoints" and "delete breakpoints" References: <20240222033601.1758-1-yangtiezhu@loongson.cn> X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > From: Tiezhu Yang > Cc: Kevin Buettner , > Tom Tromey , > Bruno Larsen , > Eli Zaretskii > Date: Thu, 22 Feb 2024 11:36:01 +0800 > > v4: make the lines shorter than 80 columns > > gdb/breakpoint.c | 25 +++++++----- > gdb/doc/gdb.texinfo | 38 ++++++++++--------- > gdb/ppc-linux-nat.c | 4 +- > gdb/testsuite/gdb.arch/i386-dr3-watch.exp | 2 +- > .../gdb.base/annota-input-while-running.exp | 2 +- > gdb/testsuite/gdb.base/break-unload-file.exp | 4 +- > gdb/testsuite/gdb.base/break.exp | 10 ++--- > .../gdb.base/breakpoint-in-ro-region.exp | 2 +- > .../continue-after-aborted-step-over.exp | 2 +- > gdb/testsuite/gdb.base/default.exp | 2 +- > gdb/testsuite/gdb.base/del.exp | 4 +- > gdb/testsuite/gdb.base/ena-dis-br.exp | 2 +- > gdb/testsuite/gdb.base/foll-fork.exp | 6 +-- > gdb/testsuite/gdb.base/hbreak-unmapped.exp | 4 +- > gdb/testsuite/gdb.base/hbreak2.exp | 2 +- > gdb/testsuite/gdb.base/help.exp | 3 +- > gdb/testsuite/gdb.base/new-ui.exp | 8 ++-- > gdb/testsuite/gdb.base/save-bp.exp | 8 ++-- > gdb/testsuite/gdb.base/sepdebug.exp | 2 +- > gdb/testsuite/gdb.base/server-del-break.exp | 4 +- > gdb/testsuite/gdb.cp/annota2.exp | 4 +- > gdb/testsuite/gdb.cp/annota3.exp | 4 +- > gdb/testsuite/gdb.cp/ovldbreak.exp | 10 ++--- > gdb/testsuite/gdb.cp/save-bp-qualified.exp | 4 +- > .../gdb.dwarf2/dw2-inline-header-1.exp | 4 +- > .../gdb.dwarf2/dw2-inline-header-2.exp | 8 ++-- > .../gdb.dwarf2/dw2-inline-header-3.exp | 4 +- > .../gdb.dwarf2/dw2-inline-small-func.exp | 4 +- > gdb/testsuite/gdb.guile/scm-breakpoint.exp | 6 +-- > gdb/testsuite/gdb.linespec/cpexplicit.exp | 4 +- > gdb/testsuite/gdb.linespec/explicit.exp | 4 +- > gdb/testsuite/gdb.mi/mi-py-modify-bp.exp | 2 +- > gdb/testsuite/gdb.mi/mi-return.exp | 2 +- > .../gdb.mi/mi-thread-specific-bp.exp | 2 +- > .../gdb.multi/inferior-specific-bp.exp | 2 +- > gdb/testsuite/gdb.opt/inline-small-func.exp | 4 +- > gdb/testsuite/gdb.python/py-breakpoint.exp | 8 ++-- > .../gdb.reverse/ppc_record_test_isa_3_1.exp | 2 +- > .../continue-pending-after-query.exp | 2 +- > .../gdb.threads/continue-pending-status.exp | 6 +-- > gdb/testsuite/gdb.threads/thread_check.exp | 4 +- > gdb/testsuite/lib/gdb.exp | 6 +-- > gdb/testsuite/lib/mi-support.exp | 10 ++--- > gdbserver/mem-break.cc | 7 ++-- > gdbserver/mem-break.h | 7 ++-- > 45 files changed, 132 insertions(+), 122 deletions(-) Thanks. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 79805486dd6..654c4824ebf 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -4343,7 +4343,8 @@ running or not, what process it is, and why it stopped. > @end table > > @menu > -* Breakpoints:: Breakpoints, watchpoints, and catchpoints > +* Breakpoints:: Breakpoints, watchpoints, tracepoints, > + and catchpoints The last line uses TABs for alignment, but Texinfo source files should not use TABs, only SPACEs. Otherwise, the documentation parts are okay. Reviewed-By: Eli Zaretskii