Re: GDB 16.0.90 available for testing

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sun, 29 Dec 2024 17:33:26 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: brobecker@adacore.com, gdb-patches@sourceware.org
> 
> > Date: Sun, 29 Dec 2024 15:11:40 +0000 (UTC)
> > From: Hannes Domani <ssbssa@yahoo.de>
> > Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> > 
> >  Am Sonntag, 29. Dezember 2024 um 13:55:25 MEZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben:
> > 
> > > 1. A compilation error in readline/input.c, due to lack of 'alarm'
> > > function.  I have reported that several months ago to the upstream
> > > Readline developers, but the solution they installed only works for
> > > MinGW64.  For mingw.org we need the following patch:
> > >
> > > --- readline/readline/input.c~0    2024-12-29 04:50:07.000000000 +0200
> > > +++ readline/readline/input.c    2024-12-29 12:32:04.196630800 +0200
> > > @@ -151,6 +151,14 @@ win32_isatty (int fd)
> > > #  define RL_TIMEOUT_USE_SELECT
> > > #else
> > > #  define RL_TIMEOUT_USE_SIGALRM
> > > +#  ifdef __MINGW32_MAJOR_VERSION
> > > +/* mingw.org's MinGW doesn't have 'alarm'.  */
> > > +unsigned int
> > > +alarm (unsigned int seconds)
> > > +{
> > > +  return 0;
> > > +}
> > > +#  endif
> > > #endif
> > >
> > > int rl_set_timeout (unsigned int, unsigned int);
> > 
> > I wonder why readline doesn't disable the whole stuff where alarm is used
> > on windows, since it doesn't work there anyways.
> 
> Chet said that's what he did, but I saw no evidence of that in the
> current Readline (assuming I was looking at the correct branch in the
> Git repository).  See
> 
>   https://lists.gnu.org/archive/html/bug-readline/2024-12/msg00003.html

Given what Chet says in

  https://lists.gnu.org/archive/html/bug-readline/2024-12/msg00006.html

I now understand how this is fixed in upstream Readline.  The fix
there is not right: it will fail the MinGW64 build.  So I'd like to
fix this properly in our repository and tell Chet how I recommend to
fix it upstream.

Should I fix this in our repository right away, or would you prefer to
wait for Chet to agree with my proposal, so that we have the same code
as in upstream Readline?