Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gcore: add -v or --version option to show version number
Date: Thu, 06 Mar 2025 19:31:20 +0200	[thread overview]
Message-ID: <865xkmm5g7.fsf@gnu.org> (raw)
In-Reply-To: <e9327d007606a588e2bb52e856670b891f952e90.1741280898.git.aburgess@redhat.com> (message from Andrew Burgess on Thu, 6 Mar 2025 17:10:22 +0000)

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Thu,  6 Mar 2025 17:10:22 +0000
> 
> Based on the work in this commit:
> 
>   commit fb2ded33c1e519659743047ed7817166545b6d91
>   Date:   Fri Dec 20 12:46:11 2024 -0800
> 
>       Add gstack script
> 
> This commit adds a '-v' or '--version' option to the existing gcore
> script.  This new option causes the script to print its version
> number, and then exit.
> 
> I needed to adjust the getopts handling a little in order to support
> the long form '--version' argument, but as this makes gcore more
> consistent with gstack, then this seems like a good thing.
> 
> The usage message is now getting a little long.  Don't worry, I plan
> to clean that up in the next commit.
> ---
>  gdb/Makefile.in              |  7 ++-----
>  gdb/NEWS                     |  3 +++
>  gdb/configure                |  5 ++---
>  gdb/configure.ac             |  2 +-
>  gdb/doc/gdb.texinfo          |  7 ++++++-
>  gdb/{gcore.in => gcore-1.in} | 23 ++++++++++++++++++++---
>  6 files changed, 34 insertions(+), 13 deletions(-)
>  rename gdb/{gcore.in => gcore-1.in} (88%)

Thanks, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2025-03-06 17:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 17:10 [PATCH 0/3] gcore: add --help and --version options Andrew Burgess
2025-03-06 17:10 ` [PATCH 1/3] gcore: add -v or --version option to show version number Andrew Burgess
2025-03-06 17:31   ` Eli Zaretskii [this message]
2025-03-06 17:10 ` [PATCH 2/3] gcore: add -h|--help options, and improve help/usage message output Andrew Burgess
2025-03-06 17:33   ` Eli Zaretskii
2025-03-06 17:10 ` [PATCH 3/3] gcore/doc: fix mistake in the gcore man page Andrew Burgess
2025-03-06 17:32   ` Eli Zaretskii
2025-03-06 20:16 ` [PATCH 0/3] gcore: add --help and --version options Tom Tromey
2025-03-06 20:19 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xkmm5g7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox