From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id udnnJgr64Gm3ShwAWB0awg (envelope-from ) for ; Thu, 16 Apr 2026 11:02:34 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=U/OQpuNi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 772011E0C3; Thu, 16 Apr 2026 11:02:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 94B611E04F for ; Thu, 16 Apr 2026 11:02:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 181E34C318AC for ; Thu, 16 Apr 2026 15:02:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 181E34C318AC Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=U/OQpuNi Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 972E94BA23FB for ; Thu, 16 Apr 2026 15:02:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 972E94BA23FB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 972E94BA23FB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776351728; cv=none; b=CXcLQYcDZkXqWnHZNEF5IzmhshEm0yYREaPDyL/OdjtNp2bccUbDq7RQPpUjyUZR9SntCi9/wtt7ztBTclaqNh6/o6ChXZj0pBf5mcq7lsPV9/od4FIbCHMnS1UOyl6z53GzO8w8aeeZDpN9nRB+Qzz3TTseAS7AMWZ7b6rEVzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776351728; c=relaxed/simple; bh=C4serlbJ9bmnnZZdYP4VBqSm/iSyilpMGnII2DiIAgI=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=dmBiCPaoIMCAts7CR0gQaT9RvbDsyROq4E/sXykj8y8wBxKVOjbHV7r9MK1ITW7dXdMoHG2J9+GZ0kQVg9xwcZ7kKxj3trIDY/Z1lx8yDrgl0SfzgQ1bhJLN80kp3l5ngN+W6W19F7A+AKRFFk19faujNaPADmTSbSGOhDqfOOA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 972E94BA23FB Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDOEI-00083c-Bp; Thu, 16 Apr 2026 11:02:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=O3l4jHzEv9CzxaryXZoZh8DcPzNQng79KVO/9q6oLUY=; b=U/OQpuNi8IiyfDN0uvbT OgLQOq7qSAiMdIt6tjPvz0rG+F1AAOEuDWO/++4QGBiql1s8SVFCXjHVPXzl/VOUjqn22RNKhcJVP OhwigQhxshubdQ6HgFtu2j6bmlgZ5e7sFEX2xW5yvWlC82X7Lx1hKKgxGRPZ/aK5ocdwmEzKu7KrY r4vXvVDcKYPz+kumwIEndPUu0v75uxpIosCroKHph8zRli0/922D7vsMsuAJkH5E/Vc3md86hVOwJ 55jYyPDx6h40kenoB6gSjO7ti/eOI9T2kqG3xgrCuX5R5jUNY862vlxVeoCJeq2xsgRJ8w0NKdlhV Xp/59tcCBqVu7w==; Date: Thu, 16 Apr 2026 18:01:56 +0300 Message-Id: <865x5rkkyj.fsf@gnu.org> From: Eli Zaretskii To: Guinevere Larsen Cc: gdb-patches@sourceware.org In-Reply-To: (message from Guinevere Larsen on Thu, 16 Apr 2026 11:03:16 -0300) Subject: Re: [PATCH 6/6] gdb/record: Define new version of the record-save section References: <20260415185836.2732968-1-guinevere@redhat.com> <20260415185836.2732968-7-guinevere@redhat.com> <86pl3zla0b.fsf@gnu.org> <5de0615d-c637-4025-9bd5-c2cc8063f1e5@redhat.com> <86bjfjkoi5.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Date: Thu, 16 Apr 2026 11:03:16 -0300 > Cc: gdb-patches@sourceware.org > From: Guinevere Larsen > > On 4/16/26 10:45 AM, Eli Zaretskii wrote: > >> Date: Thu, 16 Apr 2026 09:41:56 -0300 > >> Cc: gdb-patches@sourceware.org > >> From: Guinevere Larsen > >> > >>> Reviewed-By: Eli Zaretskii > >>> > >> This is confusing to me. You're supposed to add the review tag when > >> you're satisfied with the patch and approving it to go through. > > That's not my understanding, since I'm reviewing only part of the > > patch. What I usually do is say when I'm satisfied is "this part is > > OK" or "the documentation parts are approved". > > The point of the review tag is specifically to remove the ambiguity of > needing to look for ambiguous language like "this part is ok". As the > MAINTAINERS file explains > > - Reviewed-By: > >   Used when a contributor has looked at the code and agrees with >   the changes, but either doesn't have the authority or doesn't >   feel comfortable approving the patch. Which is exactly the case: "doesn't feel comfortable approving the patch". > >> So, do you think the explanation I gave is enough, or do you want me > >> to explain it more on the news file? > > I'd prefer that you at least mention the command(s) which produce and > > read these execution records, so that people know what is affected. > Ok will do. Thanks.