Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: tom@tromey.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] [GDB 18] gdb/configure: fix string quoting in AC_MSG_WARN and AC_MSG_ERROR
Date: Thu, 13 Aug 2026 15:21:23 +0300	[thread overview]
Message-ID: <865x1e9poc.fsf@gnu.org> (raw)
In-Reply-To: <87a4qq1j7o.fsf@redhat.com> (message from Andrew Burgess on Thu,  13 Aug 2026 10:08:11 +0100)

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 13 Aug 2026 10:08:11 +0100
> 
> Tom Tromey <tom@tromey.com> writes:
> 
> >>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
> >
> > Andrew> If / when approve I plan to push this to both master and gdb-18-branch.
> >
> > FWIW I think the patch is correct.
> > Approved-By: Tom Tromey <tom@tromey.com>
> 
> I've pushed to both master and gdb-18-branch.
> 
> I don't know if Eli will have any follow up on this feature, but even if
> wider changes to this feature are made, we might as well fix the current
> implementation.

Thanks.  If there will be another pretest, I will certainly provide
feedback.  But the change looks okay to me even without trying, since
you tested it yourself.  I was not aware that BFD had its own ideas
about what can and cannot be built, and was previously silently
omitting binary formats it couldn't support.  TIL.

      reply	other threads:[~2026-08-13 12:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 13:02 Andrew Burgess
2026-08-11 13:35 ` Eli Zaretskii
2026-08-11 16:33   ` Andrew Burgess
2026-08-12 19:02     ` Guinevere Larsen
2026-08-12 19:55 ` Tom Tromey
2026-08-13  9:08   ` Andrew Burgess
2026-08-13 12:21     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865x1e9poc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox