From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24315 invoked by alias); 7 Apr 2015 13:55:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24301 invoked by uid 89); 7 Apr 2015 13:55:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 07 Apr 2015 13:55:33 +0000 Received: by pacyx8 with SMTP id yx8so79318127pac.1 for ; Tue, 07 Apr 2015 06:55:31 -0700 (PDT) X-Received: by 10.70.136.67 with SMTP id py3mr34534688pdb.112.1428414931396; Tue, 07 Apr 2015 06:55:31 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id c8sm8162115pdj.65.2015.04.07.06.55.29 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 07 Apr 2015 06:55:30 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 03/17] Displaced stepping debug: fetch the right regcache References: <1427926454-16431-1-git-send-email-palves@redhat.com> <1427926454-16431-4-git-send-email-palves@redhat.com> Date: Tue, 07 Apr 2015 13:55:00 -0000 In-Reply-To: <1427926454-16431-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Wed, 1 Apr 2015 23:14:00 +0100") Message-ID: <864mosxcts.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00225.txt.bz2 Pedro Alves writes: > gdb/ChangeLog: > 2015-04-01 Pedro Alves > > * infrun.c (resume) : Get the > leader thread's regcache, not resume_ptid's. Hi Pedro, =46rom your change, I don't see why TP is the leader thread. > --- > gdb/infrun.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/infrun.c b/gdb/infrun.c > index cf0ef32..f23e76e 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -2374,7 +2374,7 @@ resume (enum gdb_signal sig) > && tp->control.trap_expected > && use_displaced_stepping_now_p (gdbarch, sig)) > { > - struct regcache *resume_regcache =3D get_thread_regcache (resume_p= tid); > + struct regcache *resume_regcache =3D get_thread_regcache (tp->ptid= ); > struct gdbarch *resume_gdbarch =3D get_regcache_arch (resume_regca= che); > CORE_ADDR actual_pc =3D regcache_read_pc (resume_regcache); If we get recache from TP, can we remove local variables resume_regcache, resume_gdbarch, actual_pc, and use regcache, gdbarch and pc we've got at the beginning of function resume instead? --=20 Yao (=E9=BD=90=E5=B0=A7)