From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91375 invoked by alias); 26 Nov 2015 10:38:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91364 invoked by uid 89); 26 Nov 2015 10:38:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 26 Nov 2015 10:38:30 +0000 Received: by padhx2 with SMTP id hx2so83549035pad.1 for ; Thu, 26 Nov 2015 02:38:29 -0800 (PST) X-Received: by 10.66.65.234 with SMTP id a10mr12873500pat.129.1448534309155; Thu, 26 Nov 2015 02:38:29 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id uy1sm27145593pac.39.2015.11.26.02.38.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 26 Nov 2015 02:38:28 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer. References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-8-git-send-email-antoine.tremblay@ericsson.com> Date: Thu, 26 Nov 2015 10:38:00 -0000 In-Reply-To: <1448287968-12907-8-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 23 Nov 2015 09:12:45 -0500") Message-ID: <864mg9xcyo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00543.txt.bz2 Antoine Tremblay writes: > +/* See arm.h. */ > + > +int > +condition_true (unsigned long cond, unsigned long status_reg) We need "arm_" prefix for this function. Otherwise, patch is OK. --=20 Yao (=E9=BD=90=E5=B0=A7)