From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26083 invoked by alias); 27 Nov 2015 09:33:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26049 invoked by uid 89); 27 Nov 2015 09:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 27 Nov 2015 09:33:13 +0000 Received: by padhx2 with SMTP id hx2so110377525pad.1 for ; Fri, 27 Nov 2015 01:33:12 -0800 (PST) X-Received: by 10.66.221.42 with SMTP id qb10mr56956858pac.51.1448616792111; Fri, 27 Nov 2015 01:33:12 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id ix2sm33283156pac.15.2015.11.27.01.33.08 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 27 Nov 2015 01:33:10 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 03/18] attach + target always in non-stop mode: stop all threads References: <1444836486-25679-1-git-send-email-palves@redhat.com> <1444836486-25679-4-git-send-email-palves@redhat.com> <86r3ki0vzy.fsf@gmail.com> <565357B1.4070805@redhat.com> <86oaegwxhk.fsf@gmail.com> <565731F7.3010203@redhat.com> Date: Fri, 27 Nov 2015 09:33:00 -0000 In-Reply-To: <565731F7.3010203@redhat.com> (Pedro Alves's message of "Thu, 26 Nov 2015 16:23:19 +0000") Message-ID: <864mg7wzvx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00579.txt.bz2 Pedro Alves writes: > But this the GDB thread id. If a new thread recycles an old pid/tid, it'= ll > still get a new GDB thread id. (And if GDB thread ids wrap around we have > bigger problems elsewhere, which I think we'd likely sort by simply making > gdb thread ids 64-bit instead). Oh, we compare thread->num, which is the thread id in GDB. I thought we compare process/thread id. Sorry about that. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)