From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IHNQA3HQdmfqCgEAWB0awg (envelope-from ) for ; Thu, 02 Jan 2025 12:44:17 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=JOMnnmuC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0AF291E097; Thu, 2 Jan 2025 12:44:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AA1951E05C for ; Thu, 2 Jan 2025 12:44:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5DE883858D1E for ; Thu, 2 Jan 2025 17:44:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DE883858D1E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=JOMnnmuC Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9DDC63858CD9 for ; Thu, 2 Jan 2025 17:40:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DDC63858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DDC63858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735839614; cv=none; b=B0oftQmcVY4BTatPslfgmhVHJbzy1GtfqrpJRQoERas8CHlX2q3wn0vDGWTB+FhXp03MxRVcereb9YJhCM3v33DIelzc2lkcLxRkr9jdTIxA5BEeKJ35aEv/Kw/4eUA0Odl0JRCNnqGp/WJInN0B0L0NjGL91umekyljxdI7IlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735839614; c=relaxed/simple; bh=T1/QYOrbi+O7pMLML3DMemlWicP2uam9x6Sthd03mVI=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=bv+2Soni6XM9KiIFA7JR+owYjbupkx4pGzFUUYd+M0P0MsuFoX9B7QszYpB1/z4dJ6g0UXFosGVExDUF51noZIBWuZaEDM5rAeR9r/o9etT7PFvpest+xfTjaeQfBQu2pJzG7d9DkSA3QjRz620hMu7Z+OWRPGi2MZ+xEgwtzDk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DDC63858CD9 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTPB6-0000es-GX; Thu, 02 Jan 2025 12:40:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EYEsJzPpBdp9FqBndbEeifUqP0Q1BTK+WggvPbVZNPA=; b=JOMnnmuCfij1 kc42tfZDX5P96IuXhQBUq0mpVKUuORb0UE3tSgRp5JpvQEsFqBupdKvDTPuGq8G2aoEULVIHE/XgW 7R4FJRA84Gg6FEKUeAOARAl+hlpCYPsmu9rtRzMc8PuDjEDNt8CJecnqmg7+2QixwcN0KPDcyoOPo Xhoe8YssapLiIVqWZrtY+2ryBCYhwkjqgK9UE1GVuxFFPvwCFCJMmPa3CR3qUKZH/ZZ0AeUko8Ink XS9pfOm8kb7fme+JjYYpV8RJT9HmrbByPkPdRzWa4BTUErp4+a0v1rjq0nNjZz1ILTRifIXUh+OUV dUBL1/1a2t9v9fzzakrvyw==; Date: Thu, 02 Jan 2025 19:40:07 +0200 Message-Id: <864j2hjers.fsf@gnu.org> From: Eli Zaretskii To: brobecker@adacore.com Cc: gdb-patches@sourceware.org In-Reply-To: <868qryr6nn.fsf@gnu.org> (message from Eli Zaretskii on Sun, 29 Dec 2024 14:54:36 +0200) Subject: Re: GDB 16.0.90 available for testing References: <20241229033130.D7F7F803EA@takamaka.gnat.com> <868qryr6nn.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Date: Sun, 29 Dec 2024 14:54:36 +0200 > From: Eli Zaretskii > Cc: gdb-patches@sourceware.org > > 2. Compilation error in event-top.c: > > > CXX event-top.o > In file included from d:\usr\include\winsock2.h:69, > from ./../gdbsupport/gdb_select.h:30, > from event-top.c:43: > event-top.c: In function 'fd_set* fd_copy(fd_set*, const fd_set*, int)': > event-top.c:1279:22: error: invalid conversion from 'const fd_set*' to 'fd_set*' [-fpermissive] > 1279 | if (FD_ISSET (i, src)) > | ^ > | | > | const fd_set* > d:\usr\include\winsock.h:164:50: note: initializing argument 2 of 'int __FD_ISSET(SOCKET, fd_set*)' > 164 | __CRT_ALIAS int __FD_ISSET( SOCKET __fd, fd_set *__set ) > | ~~~~~~~~^~~~~ > > I solved it with an explicit cast, like this: > > --- gdb/event-top.c~0 2024-12-29 04:50:07.000000000 +0200 > +++ gdb/event-top.c 2024-12-29 12:33:48.356713700 +0200 > @@ -1276,7 +1276,7 @@ fd_copy (fd_set *dst, const fd_set *src, > { > FD_ZERO (dst); > for (int i = 0; i < n; ++i) > - if (FD_ISSET (i, src)) > + if (FD_ISSET (i, (fd_set *)src)) > FD_SET (i, dst); > > return dst; > > But I don't know if this will produce problems for other > implementations of FD_ISSET. No one responded to this part. Is it okay to fix this, or would someone please try this first on other platforms? > 4. Running "maint selftest" finds one failure: > > Running selftest help_doc_invariants. > help doc broken invariant: command 'signal-event' help doc has over-long line > Self test failed: self-test failed at unittests/command-def-selftests.c:121 > > I fixed that with the following trivial change: > > --- gdb/windows-nat.c~0 2024-12-29 04:50:07.000000000 +0200 > +++ gdb/windows-nat.c 2024-12-29 12:54:32.346946000 +0200 > @@ -3114,9 +3114,9 @@ _initialize_windows_nat () > > add_com ("signal-event", class_run, signal_event_command, _("\ > Signal a crashed process with event ID, to allow its debugging.\n\ > -This command is needed in support of setting up GDB as JIT debugger on \ > -MS-Windows. The command should be invoked from the GDB command line using \ > -the '-ex' command-line option. The ID of the event that blocks the \ > +This command is needed in support of setting up GDB as JIT debugger on\n\ > +MS-Windows. The command should be invoked from the GDB command line using\n\ > +the '-ex' command-line option. The ID of the event that blocks the\n\ > crashed process will be supplied by the Windows JIT debugging mechanism.")); > > #ifdef __CYGWIN__ And what about this one? okay to commit?