From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oQKzJgtOKWp7hz8AWB0awg (envelope-from ) for ; Wed, 10 Jun 2026 07:44:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LhFRoLL/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8EF8B1E070; Wed, 10 Jun 2026 07:44:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BBB9E1E070 for ; Wed, 10 Jun 2026 07:44:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5FB6143413F2 for ; Wed, 10 Jun 2026 11:44:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5FB6143413F2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LhFRoLL/ Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id 6CCCB42F9B6E for ; Wed, 10 Jun 2026 11:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CCCB42F9B6E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CCCB42F9B6E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.51.188.92 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781091791; cv=none; b=MLd/CRncwwfB/WN3bJcBcu+FzeHejvMwOTaHy4V4uaNOz/91Zbz6TTR6HsuMY8fw97c3+1oo2sbgGegPC2QDPUQfSUOfSvWhwUYxUXEAD99jtnFpGgA4N/ZBRc8MeKmYvXH1gVpdI217FXjbnjT+6Yc+K6QX0wtHfABDh5DhpOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781091791; c=relaxed/simple; bh=9x5mIjuKOLekvkjXGiZlE91Mxd0fcrjQesorR1GA3Og=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=ljfMEBbUgnJ+GgU2MhVxW8gAjVU+Q2l/oZ+oGgpqIM/QAALr6HtukgZMhP6wLV4objdMvYRVoGAkKjVXH7wJWovx8JAliXUMbo0NgKVunnv6dLZSDvsgHgUbm57ueH9Qiup7nAv+aPsCMkKQeLZp6HnM0HGCDTLwBqqR6DJe3jc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LhFRoLL/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CCCB42F9B6E Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXHKw-0001i8-Fr; Wed, 10 Jun 2026 07:43:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UEarr/ZQ4QKOA3VTM8VMXqpC19QgVi5E5ib+9+NX+Wc=; b=LhFRoLL/f96u 1rt/wAt16k9PW1EcU9ARuMzQO9fm8pN/xLEhwdv6JlnYFAm2grJjFk4LIqu1fjgq0cEQHcAiN/wOr wYidMGvp4Jeltvv9u+VglXFs9RYHm58/x6KRyWlqPaFrqB5Ivlme4R//UE25ihajVuy0CHN+3OEU/ /lvd2A17rSINw+sY4sCJJQ4L4cZNDAmjTsyy/b90hAPyB6HM87XSBbGbVoDz/+Bdgidob9Lp0f3VK 2vdEJcii0wsTKcG2QJCL3suPXtgnsj7qisdwtVYZ6YpllJ7Jn5H9nKnSG/vHd+wKPf7WYTv1ba0YT CJs23NJhWlgEr2dmxNg74Q==; Date: Wed, 10 Jun 2026 14:43:06 +0300 Message-Id: <864ijar585.fsf@gnu.org> From: Eli Zaretskii To: "Schimpe, Christina" Cc: gdb-patches@sourceware.org, hjl.tools@gmail.com, keiths@redhat.com, aburgess@redhat.com In-Reply-To: (christina.schimpe@intel.com) Subject: Re: [PATCH 1/2] gdb: add maintenance set/show gcore xml-target-description command References: <20260602111122.3187712-1-christina.schimpe@intel.com> <20260602111122.3187712-2-christina.schimpe@intel.com> <867bohw2rh.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: "Schimpe, Christina" > CC: "gdb-patches@sourceware.org" , > "hjl.tools@gmail.com" , "keiths@redhat.com" > , Andrew Burgess > Date: Tue, 9 Jun 2026 21:02:12 +0000 > > > If this command controls the emission of NT_GDB_TDESC note, then why its > > name mentions a more general XML target description? Am I right in > > assuming that NT_GDB_TDESC is just part of the target description? > > If so, perhaps the xml-target-description part should be renamed, or maybe > > the NEWS text should be modified to say that the entire target description is > > emitted as XML? > > You're right. I should have been more specific. > With the NT_GDB_TDESC note the core file contains a copy of GDB's target > description XML. Without this note the corefile does not contain the target > description (see commit "gdb: write target description into core file"). > > Should we better write: > > "With this command you can control whether or not the generate-core-file command > emits the NT_GDB_TDESC note including a copy of GDB's target description XML." Yes, this would be much more clear. > > > + add_setshow_boolean_cmd ("xml-target-description", class_obscure, > > > + &maint_gcore_emit_xml_tdesc, _("\ Set whether > > gcore emits a > > > +xml-target-description."), _("\ Show whether gore emits a > > > +xml-target-description."), _("\ By default, gcore emits the note > > > +NT_GDB_TDESC.\n\ Disabling this setting will cause gcore to no longer > > > +emit this note."), > > > > This doc string has the same issue: it say GDB will emit the XML target > > description, but then goes on to say that NT_GDB_TDESC note is emitted. > > Is it better as follows: > "... gcore emits the NT_GDB_TDESC note including GDB's target description XML" Yes, thanks.