From: Mark Kettenis <kettenis@chello.nl>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/i386] FP_REGNUM_P() -> i386_fp_regnum_p() et.al.
Date: Fri, 08 Nov 2002 04:48:00 -0000 [thread overview]
Message-ID: <863cqc6xdf.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: Andrew Cagney's message of "Wed, 06 Nov 2002 14:51:44 -0500"
Andrew Cagney <ac131313@redhat.com> writes:
> The attached:
>
> - converts all the macro's into functions
>
> - makes the function checks more robust - return true when both the
> regnum matches and the ISA has the register
>
> - adds a method to test for the orig_eax register (the
> I386_LINUX_ORIG_EAX_REGNUM is moved from i386-linux-tdep.h to i386-tdep.h).
>
> Ok to commit?
Looks good, but why the move of the Linux orig_eax register test to
i386-tdep.{c|h}? I'd really keep this Linux-specific quirk isolated
in a Linux-specific file.
Ok with that change. Otherwise we might need to discuss this a bit more ;-).
Mark
next prev parent reply other threads:[~2002-11-08 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-06 11:51 Andrew Cagney
2002-11-08 4:48 ` Mark Kettenis [this message]
2002-11-08 8:34 ` Andrew Cagney
2002-11-08 8:53 ` Andrew Cagney
2002-11-08 9:04 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863cqc6xdf.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox