From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87174 invoked by alias); 16 Jul 2015 15:35:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87165 invoked by uid 89); 16 Jul 2015 15:35:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f172.google.com Received: from mail-pd0-f172.google.com (HELO mail-pd0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 16 Jul 2015 15:35:36 +0000 Received: by pdbbh15 with SMTP id bh15so746099pdb.1 for ; Thu, 16 Jul 2015 08:35:34 -0700 (PDT) X-Received: by 10.70.92.10 with SMTP id ci10mr20058126pdb.9.1437060934254; Thu, 16 Jul 2015 08:35:34 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id xs13sm8391510pac.3.2015.07.16.08.35.30 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Thu, 16 Jul 2015 08:35:33 -0700 (PDT) From: Yao Qi To: Jan Kratochvil Cc: Yao Qi , Pedro Alves , gdb-patches@sourceware.org, Andreas Arnez Subject: Re: ping: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big References: <20150205073758.GA25305@host1.jankratochvil.net> <54D33C45.4010706@redhat.com> <20150214151231.GA29106@host1.jankratochvil.net> <54E33A8D.80504@redhat.com> <20150217165629.GA24936@host1.jankratochvil.net> <55A4CDD1.6060907@gmail.com> <20150714180748.GA13461@host1.jankratochvil.net> <86fv4pjt4m.fsf@gmail.com> <20150715165849.GA12070@host1.jankratochvil.net> <867fq0jijf.fsf@gmail.com> <20150716143750.GA27870@host1.jankratochvil.net> Date: Thu, 16 Jul 2015 15:35:00 -0000 In-Reply-To: <20150716143750.GA27870@host1.jankratochvil.net> (Jan Kratochvil's message of "Thu, 16 Jul 2015 16:37:50 +0200") Message-ID: <86380ojeth.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00474.txt.bz2 Jan Kratochvil writes: > Because this testcase comes from a different bug from 2009: > https://bugzilla.redhat.com/show_bug.cgi?id=3D457187 > http://pkgs.fedoraproject.org/cgit/gdb.git/commit/?id=3D94cd124608bf0dd3= 59cb48a710800d72c21b30c3 > > That bug has been fixed in the meantime but the same testcase was reprodu= cing > this new different bug - internal error regression - so I submitted > it. I see, that is clear to me now. > > We can remove the "x/i $address" test but it was useful for the previous = bug > from 2009 as that time the internal error regression did not happen, just= the > core file was not recognized (which would not be detected by the proposed > ignoring of the "core-file" command output) and so the core file was not > available. That can be tested by the "x/i $address" test. > Yeah, I agree it is useful to keep this test there, but we need comments on the purpose of such test, for example, # Test bug https://bugzilla.redhat.com/show_bug.cgi?id=3D457187 gdb_test "x/i $address" "\r\n\[ \t\]*$address:\[ \t\]*hlt\[ \t\]*" ".text i= s readable" > > But we could be upstreaming much more Fedora testcases which I do not pla= n to. > Fedora contains many testcases - 49 > grep '^#=3D' gdb.spec|sed 's/[:+].*//'|sort|uniq -c > 49 #=3Dfedoratest > for various bugs already fixed upstream. But given there isn't enough wo= rk > resources to upstream even Fedora fixes (hacks) I have never much attempt= ed to > upstream all the testcases there. > http://pkgs.fedoraproject.org/cgit/gdb.git/tree/ > (Some/few of the testcases are also a different form of the upstreamed va= riant > of the same testcase kept to be really sure no regressions are needlessly > missed in Fedora/RHEL.) I don't work on any distribution, so I don't know. --=20 Yao (=E9=BD=90=E5=B0=A7)