From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31088 invoked by alias); 15 Oct 2015 09:10:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31078 invoked by uid 89); 15 Oct 2015 09:10:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 15 Oct 2015 09:10:02 +0000 Received: by pacao1 with SMTP id ao1so17485368pac.2 for ; Thu, 15 Oct 2015 02:10:00 -0700 (PDT) X-Received: by 10.66.102.38 with SMTP id fl6mr8926868pab.36.1444900200395; Thu, 15 Oct 2015 02:10:00 -0700 (PDT) Received: from E107787-LIN (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id ir4sm14092000pbb.93.2015.10.15.02.09.58 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 15 Oct 2015 02:09:59 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v2 2/7] Add breakpoint_from_kind target_ops for software breakpoints in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-3-git-send-email-antoine.tremblay@ericsson.com> Date: Thu, 15 Oct 2015 09:10:00 -0000 In-Reply-To: <1444063455-31558-3-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 5 Oct 2015 12:44:10 -0400") Message-ID: <8637xc4hwb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00238.txt.bz2 Antoine Tremblay writes: > +static const unsigned char* > +linux_breakpoint_from_kind (int *kind) > +{ > + if (*the_low_target.breakpoint_from_kind !=3D NULL) > + return (*the_low_target.breakpoint_from_kind) (kind); > + else > + return NULL; > +} What does returned NULL mean? We need to assert the_low_target.breakpoint_from_kind isn't NULL, as a sanity check? --=20 Yao (=E9=BD=90=E5=B0=A7)