From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130462 invoked by alias); 23 May 2016 08:52:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130448 invoked by uid 89); 23 May 2016 08:52:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 23 May 2016 08:52:46 +0000 Received: by mail-pa0-f41.google.com with SMTP id tb2so43871415pac.2 for ; Mon, 23 May 2016 01:52:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WYffi5MWdi4t4LfHfy9wxH6mIY9Z1M4zxazbBh4fJO8=; b=UxZKwYzFuVqimvHOFUeQhrVa3KdRH/8/aiQIPv97w/dxcucTC8Rt88vyPMz1iD+82y 2W4GR/082gJTTdqChbVgMsZGNA9eb4Iutp9ZG/+VGp6okiYfb2o84ZAIK0YH4+jNhODZ FhTbx4KEDyyUMj4qMUj17T7jU1iLgjn2RmQYII9CLg2/wdlf9E5xjWwyS6GUMdmEHPBU rY1t0BLP1jzKH3NJ/Wcv9NG0XH/URU0idBpdtuOp3qTAwIh2Zego+kM5+i5WpB9L3qZr UPAX1kEM6MDFhVVsI+CHylPHLUsyCm2OjWi4HAUQ9Hw96U92kQ3en2QarpnsQ49p+6Fk sPWw== X-Gm-Message-State: AOPr4FUCX/YdafWK6jm8kBXEgHZ7+5aw6yzh3AF8x4TIAbTbZQFVbdTlDZuZR6FZSoucLg== X-Received: by 10.67.1.233 with SMTP id bj9mr25636628pad.46.1463993564560; Mon, 23 May 2016 01:52:44 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id m190sm44741469pfm.29.2016.05.23.01.52.42 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 23 May 2016 01:52:43 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix PR python/17981 References: <1463629620-8915-1-git-send-email-tom@tromey.com> Date: Mon, 23 May 2016 08:52:00 -0000 In-Reply-To: <1463629620-8915-1-git-send-email-tom@tromey.com> (Tom Tromey's message of "Wed, 18 May 2016 21:47:00 -0600") Message-ID: <8637p988by.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00375.txt.bz2 Tom Tromey writes: > PR python/17981 notes that gdb.breakpoints() returns None when there > are no breakpoints; whereas an empty list or tuple would be more in > keeping with Python and the documentation. > > This patch fixes the bug by changing the no-breakpoint return to make > an empty tuple. > We need to update doc about gdb.breakpoints () for this change. >=20=20 > - /* If iteratre_over_breakpoints returns non NULL it signals an error > + /* If iterate_over_breakpoints returns non NULL it signals an error This is a typo fix, can go in as a separate patch. Otherwise, patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)