From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105201 invoked by alias); 10 Jun 2016 08:54:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105184 invoked by uid 89); 10 Jun 2016 08:54:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=512K, 512k, xxx X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 10 Jun 2016 08:54:42 +0000 Received: by mail-pf0-f193.google.com with SMTP id 66so2882389pfy.1 for ; Fri, 10 Jun 2016 01:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Wzko/ZKI/dMYwhBvvpxTaLj+glOV+pPzVFwqnh9YBIA=; b=WhWQB9IAu87R8S5e9ht+1/L03W9giyaRNrpgW3cRG+s71oK9GiHWoTn8P95YMdyHfZ 2hBzs95Ua4TG7GI2vbscHbdeVhnP1nLK4iFtbS10pN+zLHuHAzugjx0pA5a4PLsTCWXQ 8LueF9dDRzbMZqM1SI7EInaMon9FG/OBAM9wQIqOMXHUMboALUosOy/TaXrLMk19gFHe NM1UKPQRMdjkdFxjzk4wZVDgxkUujTPjB+wn+SRtDga0bwMeuHlSxWsGMy5sFA/RYwdT 16Fu+0jnwZsTYegToP9yrXE2OhTqB27vxCj1NKHXrW0JKnjXcXtB6PJUyoTZq/ORs8jm L7dw== X-Gm-Message-State: ALyK8tKugVYMEAAfN1YiJXbznSzGqPY+jcR3kBtHSkRvqT+F086CBY0y21Xt5Cr5AI62Jw== X-Received: by 10.98.0.21 with SMTP id 21mr1116522pfa.81.1465548880986; Fri, 10 Jun 2016 01:54:40 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id z184sm15901316pfz.6.2016.06.10.01.54.38 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 10 Jun 2016 01:54:40 -0700 (PDT) From: Yao Qi To: David Taylor Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Support structure offsets that are 512K bytes or larger. References: <1419.1464988584@usendtaylorx2l> Date: Fri, 10 Jun 2016 08:54:00 -0000 In-Reply-To: <1419.1464988584@usendtaylorx2l> (David Taylor's message of "Fri, 03 Jun 2016 17:16:24 -0400") Message-ID: <8637olv2yc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00194.txt.bz2 David Taylor writes: Hi David, > No regressions on x86-64 GNU/Linux. I rebuild native i686-w64-mingw32 gdb with your patch, the build is OK. The patch is good to me, some nits below. You can push it in if no other comments in 3~4 days. > * c-typeprint.c (c_type_print_base): When printing offset, use plongest,= not %d. This line is too long. > @@ -723,11 +723,12 @@ pascal_object_print_value (struct type *type, const= gdb_byte *valaddr, >=20=20 > for (i =3D 0; i < n_baseclasses; i++) > { > - int boffset =3D 0; > + LONGEST boffset =3D 0; > struct type *baseclass =3D check_typedef (TYPE_BASECLASS (type, i)= ); > const char *basename =3D type_name_no_tag (baseclass); > const gdb_byte *base_valaddr =3D NULL; > - int thisoffset; > + LONGEST thisoffset; > + volatile struct gdb_exception ex; /* XXX */ 'ex' is not used at all. > diff --git a/gdb/testsuite/gdb.base/offsets.c b/gdb/testsuite/gdb.base/of= fsets.c > new file mode 100644 > index 0000000..4923d33 > --- /dev/null > +++ b/gdb/testsuite/gdb.base/offsets.c > @@ -0,0 +1,28 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2015 Free Software Foundation, Inc. 2014 - 2016 [we start from 2014 because the test was posted in 2014] > diff --git a/gdb/testsuite/gdb.base/offsets.exp b/gdb/testsuite/gdb.base/= offsets.exp > new file mode 100644 > index 0000000..42c0c5d > --- /dev/null > +++ b/gdb/testsuite/gdb.base/offsets.exp > @@ -0,0 +1,45 @@ > +# Test big offsets > + > +# Copyright (c) 2015 Free Software Foundation, Inc. 2014 - 2016 --=20 Yao (=E9=BD=90=E5=B0=A7)