From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49721 invoked by alias); 27 Jun 2017 12:56:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43176 invoked by uid 89); 27 Jun 2017 12:56:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=fighting, H*r:sk:static., designs X-HELO: mail-it0-f52.google.com Received: from mail-it0-f52.google.com (HELO mail-it0-f52.google.com) (209.85.214.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 12:56:22 +0000 Received: by mail-it0-f52.google.com with SMTP id v202so2453853itb.1 for ; Tue, 27 Jun 2017 05:56:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qgiAKPsL8m0bIMDLlgqyAZKE5wyMM4VnPGX1km0Z9fw=; b=mH9HKJmxSowz6m4nLXyYDPDCtytep50e0hgOI65HSHSmei9jLJpbNkGRjdk647MLMt H5qFO1dmT69GGNnLGGjnAmG73mnsFEfwAon2aDLcdQlsguhDzcUJfJLsbHdRfSQHbTtl PK4kQtNqRjihROLXo9+dY1s075zSYWeqeGhGBJpKoR62ZmNZw5e/i85SFiMyySil2R2N y7ALtlJ+7niEGhfX1OD9Q0iZ7e9o05H4Q0kr6hQmL64j8KkR9zHb6DdEmJdXu9y99ii3 R+Ihuuul9uKA2W/mAXHtjt4JeN6HwARgNbWTMgBZUZRABQNPk4xI2uXfJZm3YY3aNJ+R qRHw== X-Gm-Message-State: AKS2vOxd7Rrs78AEz967UVDi/mxGwxRQ7L5HsH1Q5kem6udwtVGq9oT1 r1tQylm8C5n0uGb4 X-Received: by 10.36.245.129 with SMTP id k123mr2273030ith.1.1498568180632; Tue, 27 Jun 2017 05:56:20 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id g125sm1545735ioe.3.2017.06.27.05.56.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 27 Jun 2017 05:56:20 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 08/40] completion_list_add_name wrapper functions References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-9-git-send-email-palves@redhat.com> Date: Tue, 27 Jun 2017 12:56:00 -0000 In-Reply-To: <1496406158-12663-9-git-send-email-palves@redhat.com> (Pedro Alves's message of "Fri, 2 Jun 2017 13:22:06 +0100") Message-ID: <8637alfv2m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00727.txt.bz2 Pedro Alves writes: > I've had to adjust these macros numerous times while working on this > series, adding/removing parameters while experimenting with designs. > At some point, I got fed up with fighting the preprocessor, and > decided to make them proper functions. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * symtab.c (COMPLETION_LIST_ADD_SYMBOL) > (MCOMPLETION_LIST_ADD_SYMBOL): Delete macros, replace with ... > (completion_list_add_symbol, completion_list_add_msymbol): > ... these new functions. > (add_symtab_completions) > (default_make_symbol_completion_list_break_on_1): Adjust. It is obvious. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)