From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20170 invoked by alias); 2 Aug 2017 07:55:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17892 invoked by uid 89); 2 Aug 2017 07:55:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-it0-f53.google.com Received: from mail-it0-f53.google.com (HELO mail-it0-f53.google.com) (209.85.214.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 07:55:42 +0000 Received: by mail-it0-f53.google.com with SMTP id h199so19826059ith.0 for ; Wed, 02 Aug 2017 00:55:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=E4Qib/orOnIwqY6XmwberMUkEQEuVyl+OZ7nZbqiS7w=; b=QSke/VT5Xi6Gqj+xl6vW2Ab2rDvEQjzAC/SKT0LsWIbXJSxdtUrJcxxd7OpksLUa5+ v9/t8IP2UQ7c/8ICHLiIXEyFxudlR6JkbEWb0Vd7F5iTLx7a7WkNNROlm90jxnKmO1VU mpe2UbK9fq6dHDr9FBw6eI24SXw+kEpycSaJyQgdMZ91W65OkezXiaATwyqKV3UoQPk3 0z1VfvKFcDS+TR0tHkY/tM+xgOL4/AKGf6f3WIi0Iaj2Is10Mz2zPhVKYNGdQFRte1RA 0BLwBEmiq80XWJsBv3E/wd3Gda0uv8OYYb7naRO9GK9tLKaj+6T2oJSGoZMdJHZB4o0q D5zA== X-Gm-Message-State: AIVw111aH44mx6ZJmosSM2ZxHn4KPl95ULi00SymVluWp9DfmA9Fr6Xa S2F0g9SNDoO3i1+S X-Received: by 10.36.2.202 with SMTP id 193mr4453131itu.21.1501660540393; Wed, 02 Aug 2017 00:55:40 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id x2sm1734332ita.43.2017.08.02.00.55.39 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 02 Aug 2017 00:55:39 -0700 (PDT) From: Yao Qi To: Weimin Pan Cc: Subject: Re: [PATCH v4] gdb: ADI support References: Date: Wed, 02 Aug 2017 07:55:00 -0000 In-Reply-To: (Weimin Pan's message of "Tue, 1 Aug 2017 16:29:57 -0700 (PDT)") Message-ID: <86379a4d55.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00020.txt.bz2 Weimin Pan writes: >> gdb_test "adi x shmaddr" "${hex}00:.*\t0.*" "examine ADI" > > Or change it to: > > gdb_test "adi x shmaddr" "${hex}00:\t0 " "examine ADI" > Why does it print a trailing space? Can we remove it? It is from the for loop in adi_print_versions, + for (int i =3D maxelts; i > 0 && cnt > 0; i--, cnt--) + { + if (tags[v_idx] =3D=3D 0xff) /* no version tag */ + printf_filtered ("- "); + else + printf_filtered ("%1X ", tags[v_idx]); + ++v_idx; + } >> >> >> > gdb_test "adi x/100 shmaddr" "${hex}00:\t${newadi} ${newadi}" \ >> > "examine new ADI" >> >> It will pass if changed to: >> >> gdb_test "adi x/100 shmaddr" "${hex}00:.*\t${newadi} ${newadi}.*" \ >> "examine new ADI" > > Or change it to: > > gdb_test "adi x/100 shmaddr" "${hex}00:\t${newadi} ${newadi} " \ > "examine new ADI" > Likewise. >> >> >> (gdb) PASS: gdb.arch/sparc64-adi.exp: reset ADI >> >> continue^M >> >> Continuing.^M >> >> ^M >> >> Program received signal SIGSEGV, Segmentation fault^M >> >> ADI precise mismatch while accessing address 0xfff8000100048000.^M >> >> 0xfff8000100129f38 in adi_set_version () from /usr/lib64/libadi.so^M >> > gdb_test "continue" \ >> > [multi_line "Program received signal SIGSEGV, Segmentation f= ault" \ >> > "ADI precise mismatch while accessing address $h= ex" ] \ >> > "continue to sigsegv" >> >> And it will pass if changed to >> >> gdb_test "continue" \ >> [multi_line ".*Program received signal SIGSEGV, Segmentation f= ault.*" \ >> ".*ADI precise mismatch while accessing address $h= ex.*" ] \ >> "continue to sigsegv" > > Or change it to: > > gdb_test "continue" \ > [multi_line "Program received signal SIGSEGV, Segmentation fault= .*" \ > "ADI precise mismatch while accessing address $hex.*= " ] \ > "continue to sigsegv" That is OK. --=20 Yao (=E9=BD=90=E5=B0=A7)