Re: ping#2: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones

Yao Qi
2017-10-30T11:31:05Z

Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Forget to mention in my last email,

> +// TRUE means this kernel has fixed PR external/20207.
> +// Fixed kernel supports any contiguous range of bits in 8-bit byte
> +// DR_CONTROL_MASK. Buggy kernel supports only 0x01, 0x03, 0x0f and 0xff.
> +static bool have_any_contiguous (true);

We still use /* */ for multi-line comments...

> +
> +// Return starting byte (0..7) of a watchpoint encoded by CTRL.
> +

... and function comment.

> +unsigned int
> +aarch64_watchpoint_offset (unsigned int ctrl)
> +{
> + uint8_t mask = DR_CONTROL_MASK (ctrl);
> + unsigned retval;
> +
> + // Shift out bottom zeroes.
> + for (retval = 0; mask && (mask & 1) == 0; ++retval)
> + mask >>= 1;
> +
> + return retval;
> +}
> +

--
Yao (齐尧)