[obv] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests [Re: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones]

Jan Kratochvil
2018-05-08T12:27:39Z

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

On Tue, 08 May 2018 14:08:11 +0200, Ulrich Weigand wrote:
> Jan Kratochvil wrote:
>
> > PR breakpoints/19806 and support for PR external/20207.
> > * gdb.base/watchpoint-unaligned.c: New file.
> > * gdb.base/watchpoint-unaligned.exp: New file.
>
> These new tests all fail on SPU. It looks like the test requires
> hardware watchpoints, should it check for [skip_hw_watchpoint_tests] ?

I was not aware of skip_hw_watchpoint_tests, checked in as obvious.

Thanks,
Jan

[-- Attachment #2: Type: message/rfc822, Size: 1359 bytes --]

From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH] watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests
Date: Tue, 8 May 2018 14:26:19 +0200

gdb/testsuite/ChangeLog
2018-05-08 Jan Kratochvil <jan.kratochvil@redhat.com>

* gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.base/watchpoint-unaligned.exp | 4 ++++
2 files changed, 8 insertions(+)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 761fb7334c..d6db46916e 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2018-05-08 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/watchpoint-unaligned.exp: Use skip_hw_watchpoint_tests.
+
2018-05-04 Tom Tromey <tom@tromey.com>

PR python/22730:
diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp
index 6bdd4b6d05..66358f2747 100644
--- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp
+++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp
@@ -17,6 +17,10 @@

# Test inserting read watchpoints on unaligned addresses.

+if {[skip_hw_watchpoint_tests]} {
+ return 0
+}
+
standard_testfile
if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
return -1
--
2.14.3