From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2069 invoked by alias); 4 Aug 2015 10:18:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2060 invoked by uid 89); 4 Aug 2015 10:18:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 04 Aug 2015 10:18:52 +0000 Received: by pasy3 with SMTP id y3so5125496pas.2 for ; Tue, 04 Aug 2015 03:18:50 -0700 (PDT) X-Received: by 10.68.205.167 with SMTP id lh7mr6356987pbc.48.1438683530410; Tue, 04 Aug 2015 03:18:50 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id qn7sm895586pab.14.2015.08.04.03.18.48 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 04 Aug 2015 03:18:49 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver. References: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com> Date: Tue, 04 Aug 2015 10:18:00 -0000 In-Reply-To: <1438353367-24936-1-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Fri, 31 Jul 2015 10:36:07 -0400") Message-ID: <861tfje4qq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00067.txt.bz2 Antoine Tremblay writes: Hi Antoine, I am lost in the description of your patch. > Without this patch, when doing a software single step, with for example > a conditional breakpoint, gdbserver would wrongly avance the pc of > breakpoint_len and skip an instruction. GDBserver doesn't support software single step. Does your patch fix some bug in current GDBserver or in GDBserver with software single step enabled? If it is the latter, then, you need to include this patch in your patch series supporting software single step in GDBserver, rather than sending it separately. --=20 Yao (=E9=BD=90=E5=B0=A7)