From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24722 invoked by alias); 22 Sep 2015 16:09:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24713 invoked by uid 89); 22 Sep 2015 16:09:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 22 Sep 2015 16:09:23 +0000 Received: by pacfv12 with SMTP id fv12so13249396pac.2 for ; Tue, 22 Sep 2015 09:09:21 -0700 (PDT) X-Received: by 10.66.233.164 with SMTP id tx4mr31785217pac.21.1442938161873; Tue, 22 Sep 2015 09:09:21 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id zf5sm3129158pbc.36.2015.09.22.09.09.19 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 22 Sep 2015 09:09:21 -0700 (PDT) From: Yao Qi To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] Add new gdbarch method, unconditional_branch_address References: <20150818235334.1afb0c85@pinnacle.lan> <20150819000002.06f6a2cf@pinnacle.lan> Date: Tue, 22 Sep 2015 16:09:00 -0000 In-Reply-To: <20150819000002.06f6a2cf@pinnacle.lan> (Kevin Buettner's message of "Wed, 19 Aug 2015 00:00:02 -0700") Message-ID: <861tdqbfma.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00529.txt.bz2 Kevin Buettner writes: > Add new gdbarch method, unconditional_branch_address. > > gdb/ChangeLog: > > * gdbarch.sh (unconditional_branch_address): New gdbarch method. > * gdbarch.h, gdbarch.c: Regenerate. > * arch-utils.h (default_unconditional_branch_address): Declare. > * arch-utils.c (default_unconditional_branch_address): New function. Hi Kevin, Did you consider using existing gdbarch method adjust_breakpoint_address when you wrote the patch? Can we use adjust_breakpoint_address here rather than adding a new gdbarch method? --=20 Yao (=E9=BD=90=E5=B0=A7)