From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8552 invoked by alias); 3 Nov 2015 16:22:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8542 invoked by uid 89); 3 Nov 2015 16:22:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 03 Nov 2015 16:22:03 +0000 Received: by pabfh17 with SMTP id fh17so22519178pab.0 for ; Tue, 03 Nov 2015 08:22:02 -0800 (PST) X-Received: by 10.66.236.129 with SMTP id uu1mr24165178pac.63.1446567721938; Tue, 03 Nov 2015 08:22:01 -0800 (PST) Received: from E107787-LIN (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id qy7sm30434554pab.37.2015.11.03.08.21.59 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 03 Nov 2015 08:22:01 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH 01/10] Fix breakpoint size when stepping over a permanent breakpoint in GDBServer. References: <1446138583-13268-1-git-send-email-antoine.tremblay@ericsson.com> <1446138583-13268-2-git-send-email-antoine.tremblay@ericsson.com> Date: Tue, 03 Nov 2015 16:22:00 -0000 In-Reply-To: <1446138583-13268-2-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Thu, 29 Oct 2015 13:09:34 -0400") Message-ID: <861tc7yrx9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00112.txt.bz2 Antoine Tremblay writes: > static int > -arm_breakpoint_at (CORE_ADDR where) > +arm_is_thumb_mode (void) > { Please add comments to arm_is_thumb_mode. > diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h > index 769c876..f0fb9d7 100644 > --- a/gdb/gdbserver/target.h > +++ b/gdb/gdbserver/target.h > @@ -451,6 +451,12 @@ struct target_ops > specific meaning like the Z0 kind parameter. > SIZE is set to the software breakpoint's length in memory. */ > const gdb_byte *(*sw_breakpoint_from_kind) (int kind, int *size); > + > + /* Return the breakpoint kind for this target based on the current sta= te Maybe "current machine state" or "current processor state" is better than "current state"? > + (e.g. the current instruction mode on ARM) and the PC. The PCPTR is Two spaces before "The PCPTR". > + adjusted to the real memory location in case a flag (e.g., the Thumb > + bit on ARM) was present in the PC. */ "is present in the PC." ? Otherwise, looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)